Hi Krzysztof Kozlowski:

Thank you for your advice, I will change these questions

Add a DT schema for describing Awinic AW883xx audio amplifiers. They are controlled using I2C.

Signed-off-by: Weidong Wang wangweidong.a@awinic.com

.../bindings/sound/awinic,aw883xx.yaml | 62 +++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml

diff --git a/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml new file mode 100644 index 000000000000..04cdcf25a6d4 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/awinic,aw883xx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Awinic AW883xx Smart Audio Amplifier

+maintainers:

• • Stephan Gerhold stephan@gerhold.net

+description:

• The Awinic AW883XX is an I2S/TDM input, high efficiency
• digital Smart K audio amplifier with an integrated 10.25V
• smart boost convert.

+allOf:

• • $ref: name-prefix.yaml#

+properties:

• compatible:
• const: awinic,aw883xx_smartpa
• reg:
• description:

•  The I2C address of the device for I2C
  

What happened here? This was not present before. Drop description.

I will delete this description in patch v5

• maxItems: 1
• reset-gpios:
• description:

•  Reset pin of aw883xx chip
  

The same case. Drop description.

I commented only for irq-gpios that they need description.

I will delete this description in patch v5

• maxItems: 1
• sound-channel:
• description:

•  Number of sound channels of the aw883xx chip
  

Your description does not explain me much. Number of supported sound channels is usually fixed in the hardware, thus coming from compatible. Therefore this might mean something else... but anyway your driver does not use it really, so just drop it.

I will delete this description in patch v5