[alsa-devel] [PATCH -next] ASoC: fsl_mqs: fix old-style function declaration
gcc warn about this:
sound/soc/fsl/fsl_mqs.c:146:1: warning: static is not at beginning of declaration [-Wold-style-declaration]
Signed-off-by: YueHaibing yuehaibing@huawei.com --- sound/soc/fsl/fsl_mqs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c index f7fc44e..0c813a4 100644 --- a/sound/soc/fsl/fsl_mqs.c +++ b/sound/soc/fsl/fsl_mqs.c @@ -143,7 +143,7 @@ static void fsl_mqs_shutdown(struct snd_pcm_substream *substream, MQS_EN_MASK, 0); }
-const static struct snd_soc_component_driver soc_codec_fsl_mqs = { +static const struct snd_soc_component_driver soc_codec_fsl_mqs = { .idle_bias_on = 1, .non_legacy_dai_naming = 1, };
On Okt 11 2019, YueHaibing yuehaibing@huawei.com wrote:
gcc warn about this:
sound/soc/fsl/fsl_mqs.c:146:1: warning: static is not at beginning of declaration [-Wold-style-declaration]
It's not a function, though.
Andreas.
On 2019/10/11 21:12, Andreas Schwab wrote:
On Okt 11 2019, YueHaibing yuehaibing@huawei.com wrote:
gcc warn about this:
sound/soc/fsl/fsl_mqs.c:146:1: warning: static is not at beginning of declaration [-Wold-style-declaration]
It's not a function, though.
Oh..., will fix this, thanks!
Andreas.
gcc warn about this:
sound/soc/fsl/fsl_mqs.c:146:1: warning: static is not at beginning of declaration [-Wold-style-declaration]
Signed-off-by: YueHaibing yuehaibing@huawei.com --- v2: Fix patch title --- sound/soc/fsl/fsl_mqs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c index f7fc44e..0c813a4 100644 --- a/sound/soc/fsl/fsl_mqs.c +++ b/sound/soc/fsl/fsl_mqs.c @@ -143,7 +143,7 @@ static void fsl_mqs_shutdown(struct snd_pcm_substream *substream, MQS_EN_MASK, 0); }
-const static struct snd_soc_component_driver soc_codec_fsl_mqs = { +static const struct snd_soc_component_driver soc_codec_fsl_mqs = { .idle_bias_on = 1, .non_legacy_dai_naming = 1, };
On Fri, Oct 11, 2019 at 10:35:38PM +0800, YueHaibing wrote:
gcc warn about this:
sound/soc/fsl/fsl_mqs.c:146:1: warning: static is not at beginning of declaration [-Wold-style-declaration]
Signed-off-by: YueHaibing yuehaibing@huawei.com
Acked-by: Nicolin Chen nicoleotsuka@gmail.com
v2: Fix patch title
sound/soc/fsl/fsl_mqs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c index f7fc44e..0c813a4 100644 --- a/sound/soc/fsl/fsl_mqs.c +++ b/sound/soc/fsl/fsl_mqs.c @@ -143,7 +143,7 @@ static void fsl_mqs_shutdown(struct snd_pcm_substream *substream, MQS_EN_MASK, 0); }
-const static struct snd_soc_component_driver soc_codec_fsl_mqs = { +static const struct snd_soc_component_driver soc_codec_fsl_mqs = { .idle_bias_on = 1, .non_legacy_dai_naming = 1, }; -- 2.7.4
The patch
ASoC: fsl_mqs: Move static keyword to the front of declarations
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.5
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From dd79841ca66ff509660880237dc286d7f116a766 Mon Sep 17 00:00:00 2001
From: YueHaibing yuehaibing@huawei.com Date: Fri, 11 Oct 2019 22:35:38 +0800 Subject: [PATCH] ASoC: fsl_mqs: Move static keyword to the front of declarations
gcc warn about this:
sound/soc/fsl/fsl_mqs.c:146:1: warning: static is not at beginning of declaration [-Wold-style-declaration]
Signed-off-by: YueHaibing yuehaibing@huawei.com Acked-by: Nicolin Chen nicoleotsuka@gmail.com Link: https://lore.kernel.org/r/20191011143538.15300-1-yuehaibing@huawei.com Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/fsl/fsl_mqs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c index f7fc44e8fb27..0c813a45bba7 100644 --- a/sound/soc/fsl/fsl_mqs.c +++ b/sound/soc/fsl/fsl_mqs.c @@ -143,7 +143,7 @@ static void fsl_mqs_shutdown(struct snd_pcm_substream *substream, MQS_EN_MASK, 0); }
-const static struct snd_soc_component_driver soc_codec_fsl_mqs = { +static const struct snd_soc_component_driver soc_codec_fsl_mqs = { .idle_bias_on = 1, .non_legacy_dai_naming = 1, };
participants (4)
-
Andreas Schwab -
Mark Brown -
Nicolin Chen -
YueHaibing