[alsa-devel] [patch] alsa-utils fix for intl support
Hi,
Feel free to comment on the included patch. I had to add it because aseqnet would not link without -lintl.
At Thu, 4 Dec 2008 15:29:47 +0100, Hans-Christian Egtvedt wrote:
Hi,
Feel free to comment on the included patch. I had to add it because aseqnet would not link without -lintl.
Patching Makefile.in doesn't make any sense. Does the patch below work instead?
thanks,
Takashi
diff --git a/seq/aseqnet/Makefile.am b/seq/aseqnet/Makefile.am index cda8815..aa3aa77 100644 --- a/seq/aseqnet/Makefile.am +++ b/seq/aseqnet/Makefile.am @@ -3,4 +3,5 @@ EXTRA_DIST = README.aseqnet aseqnet.1
bin_PROGRAMS = aseqnet aseqnet_SOURCES = aseqnet.c +LIBADD = $(INTLLIBS) man_MANS = aseqnet.1
On Mon, 08 Dec 2008 08:32:42 +0100 Takashi Iwai tiwai@suse.de wrote:
At Thu, 4 Dec 2008 15:29:47 +0100, Hans-Christian Egtvedt wrote:
Hi,
Feel free to comment on the included patch. I had to add it because aseqnet would not link without -lintl.
Patching Makefile.in doesn't make any sense.
I have quite low fu with autoconf, but sure Makefile.in does not need a patch as well? There are no users of LIBADD in seq/aseqnet/Makefile.in.
Does the patch below work instead?
Nope, still not able to find libintl.
What is the correct way of testing this? From a fresh 1.0.18 source I changed seq/aseqnet/Makefile.am and then ran autoreconf before ./configure + make. Should I have used more/other autotools?
<snipp Makefile.am patch>
At Mon, 8 Dec 2008 10:29:05 +0100, Hans-Christian Egtvedt wrote:
On Mon, 08 Dec 2008 08:32:42 +0100 Takashi Iwai tiwai@suse.de wrote:
At Thu, 4 Dec 2008 15:29:47 +0100, Hans-Christian Egtvedt wrote:
Hi,
Feel free to comment on the included patch. I had to add it because aseqnet would not link without -lintl.
Patching Makefile.in doesn't make any sense.
I have quite low fu with autoconf, but sure Makefile.in does not need a patch as well? There are no users of LIBADD in seq/aseqnet/Makefile.in.
No, Makefile.in is created by Makefile.am.
Does the patch below work instead?
Nope, still not able to find libintl.
Then something other is missing.
What is the correct way of testing this? From a fresh 1.0.18 source I changed seq/aseqnet/Makefile.am and then ran autoreconf before ./configure + make. Should I have used more/other autotools?
No, it should work. Even without autoreconf, configure itself should check the change of Makefile.am.
Takashi
At Mon, 08 Dec 2008 10:42:24 +0100, I wrote:
At Mon, 8 Dec 2008 10:29:05 +0100, Hans-Christian Egtvedt wrote:
On Mon, 08 Dec 2008 08:32:42 +0100 Takashi Iwai tiwai@suse.de wrote:
At Thu, 4 Dec 2008 15:29:47 +0100, Hans-Christian Egtvedt wrote:
Hi,
Feel free to comment on the included patch. I had to add it because aseqnet would not link without -lintl.
Patching Makefile.in doesn't make any sense.
I have quite low fu with autoconf, but sure Makefile.in does not need a patch as well? There are no users of LIBADD in seq/aseqnet/Makefile.in.
No, Makefile.in is created by Makefile.am.
Does the patch below work instead?
Nope, still not able to find libintl.
Then something other is missing.
It was a typo. Must be LDADD, not LIBADD. Fixed on git now.
thanks,
Takashi
On Mon, 08 Dec 2008 12:01:15 +0100 Takashi Iwai tiwai@suse.de wrote:
At Mon, 08 Dec 2008 10:42:24 +0100, I wrote:
<snipp>
Nope, still not able to find libintl.
Then something other is missing.
It was a typo. Must be LDADD, not LIBADD. Fixed on git now.
Ah, great, then I can understand that it will work :)
Just tested an updated patch (with LDADD instead of LIBADD), and it works fine on my system.
Thanks for your help on my two patches.
participants (2)
-
Hans-Christian Egtvedt -
Takashi Iwai