[alsa-devel] [PATCH -next] ASoC: ux500: Fix sparse non static symbol warning
From: Wei Yongjun yongjun_wei@trendmicro.com.cn
Fixes the following sparse warning:
sound/soc/ux500/ux500_msp_i2s.c:649:5: warning: symbol 'ux500_msp_i2s_of_init_msp' was not declared. Should it be static?
Signed-off-by: Wei Yongjun yongjun_wei@trendmicro.com.cn --- sound/soc/ux500/ux500_msp_i2s.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c index 7f2a4ac..959d7b4 100644 --- a/sound/soc/ux500/ux500_msp_i2s.c +++ b/sound/soc/ux500/ux500_msp_i2s.c @@ -646,9 +646,9 @@ int ux500_msp_i2s_close(struct ux500_msp *msp, unsigned int dir)
}
-int ux500_msp_i2s_of_init_msp(struct platform_device *pdev, - struct ux500_msp *msp, - struct msp_i2s_platform_data **platform_data) +static int ux500_msp_i2s_of_init_msp(struct platform_device *pdev, + struct ux500_msp *msp, + struct msp_i2s_platform_data **platform_data) { struct msp_i2s_platform_data *pdata;
On Wednesday 08 January 2014 18:13:35 Wei Yongjun wrote:
From: Wei Yongjun yongjun_wei@trendmicro.com.cn
Fixes the following sparse warning:
sound/soc/ux500/ux500_msp_i2s.c:649:5: warning: symbol 'ux500_msp_i2s_of_init_msp' was not declared. Should it be static?
Signed-off-by: Wei Yongjun yongjun_wei@trendmicro.com.cn
Acked-by: Arnd Bergmann arnd@arndb.de
On Wed, Jan 8, 2014 at 11:13 AM, Wei Yongjun weiyj.lk@gmail.com wrote:
From: Wei Yongjun yongjun_wei@trendmicro.com.cn
Fixes the following sparse warning:
sound/soc/ux500/ux500_msp_i2s.c:649:5: warning: symbol 'ux500_msp_i2s_of_init_msp' was not declared. Should it be static?
Signed-off-by: Wei Yongjun yongjun_wei@trendmicro.com.cn
Lee, is this something that needs to go along with your patches to ASoC or can I apply this separately?
Yours, Linus Walleij
On Wed, 08 Jan 2014, Linus Walleij wrote:
On Wed, Jan 8, 2014 at 11:13 AM, Wei Yongjun weiyj.lk@gmail.com wrote:
From: Wei Yongjun yongjun_wei@trendmicro.com.cn
Fixes the following sparse warning:
sound/soc/ux500/ux500_msp_i2s.c:649:5: warning: symbol 'ux500_msp_i2s_of_init_msp' was not declared. Should it be static?
Signed-off-by: Wei Yongjun yongjun_wei@trendmicro.com.cn
FWIW: Acked-by: Lee Jones lee.jones@linaro.org
Lee, is this something that needs to go along with your patches to ASoC or can I apply this separately?
If Mark takes it, then it will just apply as my patches have already been applied.
On Wed, Jan 8, 2014 at 12:06 PM, Lee Jones lee.jones@linaro.org wrote:
On Wed, 08 Jan 2014, Linus Walleij wrote:
On Wed, Jan 8, 2014 at 11:13 AM, Wei Yongjun weiyj.lk@gmail.com wrote:
From: Wei Yongjun yongjun_wei@trendmicro.com.cn
Fixes the following sparse warning:
sound/soc/ux500/ux500_msp_i2s.c:649:5: warning: symbol 'ux500_msp_i2s_of_init_msp' was not declared. Should it be static?
Signed-off-by: Wei Yongjun yongjun_wei@trendmicro.com.cn
FWIW: Acked-by: Lee Jones lee.jones@linaro.org
Lee, is this something that needs to go along with your patches to ASoC or can I apply this separately?
If Mark takes it, then it will just apply as my patches have already been applied.
Mark can you take this patch to minimize the fuzz?
Yours, Linus Walleij
On Wed, Jan 08, 2014 at 06:13:35PM +0800, Wei Yongjun wrote:
From: Wei Yongjun yongjun_wei@trendmicro.com.cn
Fixes the following sparse warning:
Applied, thanks.
participants (5)
-
Arnd Bergmann
-
Lee Jones
-
Linus Walleij
-
Mark Brown
-
Wei Yongjun