[alsa-devel] [PATCH] ASoC: max98090: Remove empty suspend function
The suspend function is empty so can be removed.
Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/max98090.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index da23810f958e..68271042f586 100644 --- a/sound/soc/codecs/max98090.c +++ b/sound/soc/codecs/max98090.c @@ -2838,15 +2838,10 @@ static int max98090_resume(struct device *dev)
return 0; } - -static int max98090_suspend(struct device *dev) -{ - return 0; -} #endif
static const struct dev_pm_ops max98090_pm = { - SET_RUNTIME_PM_OPS(max98090_runtime_suspend, + SET_RUNTIME_PM_OPS(NULL, max98090_runtime_resume, NULL) SET_SYSTEM_SLEEP_PM_OPS(max98090_suspend, max98090_resume) };
On Thu, Dec 19, 2019 at 2:59 AM Mark Brown broonie@kernel.org wrote:
The suspend function is empty so can be removed.
Signed-off-by: Mark Brown broonie@kernel.org
sound/soc/codecs/max98090.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index da23810f958e..68271042f586 100644 --- a/sound/soc/codecs/max98090.c +++ b/sound/soc/codecs/max98090.c @@ -2838,15 +2838,10 @@ static int max98090_resume(struct device *dev)
return 0;
}
-static int max98090_suspend(struct device *dev) -{
return 0;
-} #endif
static const struct dev_pm_ops max98090_pm = {
SET_RUNTIME_PM_OPS(max98090_runtime_suspend,
SET_RUNTIME_PM_OPS(NULL, max98090_runtime_resume, NULL)
You replaced the wrong "_suspend".
SET_SYSTEM_SLEEP_PM_OPS(max98090_suspend, max98090_resume)
This is which you should replace to NULL.
On Thu, Dec 19, 2019 at 05:59:24AM +0800, Tzung-Bi Shih wrote:
On Thu, Dec 19, 2019 at 2:59 AM Mark Brown broonie@kernel.org wrote:
SET_SYSTEM_SLEEP_PM_OPS(max98090_suspend, max98090_resume)
This is which you should replace to NULL.
Ugh, so I did - thanks.
participants (2)
-
Mark Brown
-
Tzung-Bi Shih