[alsa-devel] Add quirk for Lenovo X1 Yoga
Dne 08. 01. 20 v 10:19 Kailang napsal(a):
Hi Takashi,
Attach patch was for Lenovo X1 Yoga.
Remove the 'Fixes:' line. It's the different device. Otherwise:
Reviewed-by: Jaroslav Kysela perex@perex.cz
BR, Kailang
Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Hi Jaroslav,
Had Your Redhat kernel implement the Intel SOF driver? PCH Dmic need to enable by SOF driver. If it had SOF driver, it doesn't need to apply this patch. SOF could via UCM to control bass speaker volume.
BR, Kailang
-----Original Message----- From: Jaroslav Kysela perex@perex.cz Sent: Wednesday, January 8, 2020 5:30 PM To: Kailang kailang@realtek.com; Takashi Iwai (tiwai@suse.de) tiwai@suse.de Cc: (alsa-devel@alsa-project.org) alsa-devel@alsa-project.org Subject: Re: [alsa-devel] Add quirk for Lenovo X1 Yoga
Dne 08. 01. 20 v 10:19 Kailang napsal(a):
Hi Takashi,
Attach patch was for Lenovo X1 Yoga.
Remove the 'Fixes:' line. It's the different device. Otherwise:
Reviewed-by: Jaroslav Kysela perex@perex.cz
BR, Kailang
Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
-- Jaroslav Kysela perex@perex.cz Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
------Please consider the environment before printing this e-mail.
Dne 08. 01. 20 v 10:37 Kailang napsal(a):
Hi Jaroslav,
Had Your Redhat kernel implement the Intel SOF driver? PCH Dmic need to enable by SOF driver. If it had SOF driver, it doesn't need to apply this patch. SOF could via UCM to control bass speaker volume.
Hi,
It's not correct. Those platforms have 4 speakers and we need to route the stereo stream to all of them. The SOF driver uses the same HDA codec driver as the HDA legacy driver (snd-hda-intel), so the situation is similar. UCM just controls, if the second pair speakers is activated or not.
So, we need this for both legacy and SOF, otherwise the "bass" speakers will be routed from another HDA DAC.
Jaroslav
BR, Kailang
-----Original Message----- From: Jaroslav Kysela perex@perex.cz Sent: Wednesday, January 8, 2020 5:30 PM To: Kailang kailang@realtek.com; Takashi Iwai (tiwai@suse.de) tiwai@suse.de Cc: (alsa-devel@alsa-project.org) alsa-devel@alsa-project.org Subject: Re: [alsa-devel] Add quirk for Lenovo X1 Yoga
Dne 08. 01. 20 v 10:19 Kailang napsal(a):
Hi Takashi,
Attach patch was for Lenovo X1 Yoga.
Remove the 'Fixes:' line. It's the different device. Otherwise:
Reviewed-by: Jaroslav Kysela perex@perex.cz
BR, Kailang
Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
-- Jaroslav Kysela perex@perex.cz Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
------Please consider the environment before printing this e-mail.
On Wed, 08 Jan 2020 10:29:53 +0100, Jaroslav Kysela wrote:
Dne 08. 01. 20 v 10:19 Kailang napsal(a):
Hi Takashi,
Attach patch was for Lenovo X1 Yoga.
Remove the 'Fixes:' line. It's the different device. Otherwise:
Reviewed-by: Jaroslav Kysela perex@perex.cz
OK, I updated the description and removed the fixes tag. Now applied.
thanks,
Takashi
BR, Kailang
Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
-- Jaroslav Kysela perex@perex.cz Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
participants (3)
-
Jaroslav Kysela -
Kailang -
Takashi Iwai