From: Julia Lawall Julia.Lawall@lip6.fr

Of_node_put supports NULL as its argument, so the initial test is not necessary.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/)

// <smpl> @@ expression e; @@

-if (e) of_node_put(e); // </smpl>

Signed-off-by: Julia Lawall Julia.Lawall@lip6.fr

--- sound/soc/sh/rcar/core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c index 19f7896..1922ec5 100644 --- a/sound/soc/sh/rcar/core.c +++ b/sound/soc/sh/rcar/core.c @@ -798,10 +798,8 @@ if (name##_node) { \ mod_parse(src); mod_parse(dvc);

- if (playback) - of_node_put(playback); - if (capture) - of_node_put(capture); + of_node_put(playback); + of_node_put(capture); }

dai_i++;