On 27/7/23 08:16, Dan Carpenter wrote:

Smatch complains that this return should be a goto:

 sound/pci/hda/cs35l56_hda.c:910 cs35l56_hda_common_probe()
 warn: missing unwind goto?

The goto error disables cansleep so that seems reasonable.

Fixes: 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier") Signed-off-by: Dan Carpenter dan.carpenter@linaro.org

---

sound/pci/hda/cs35l56_hda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c index 71e95e64f8a4..4c3279f61b94 100644 --- a/sound/pci/hda/cs35l56_hda.c +++ b/sound/pci/hda/cs35l56_hda.c @@ -907,7 +907,7 @@ int cs35l56_hda_common_probe(struct cs35l56_hda *cs35l56, int id)

ret = cs35l56_set_patch(&cs35l56->base); if (ret)

• return ret;
  

• goto err;
  
  

  regcache_mark_dirty(cs35l56->base.regmap); regcache_sync(cs35l56->base.regmap);

Thanks.

Reviewed-by: Richard Fitzgerald rf@opensource.cirrus.com