At Mon, 11 Mar 2013 11:03:09 +0100, David Henningsson wrote:

Hi Takashi,

Should this patch be sent to stable?

commit 8b8d654b55648561287bd8baca0f75f964a17038 Author: Takashi Iwai tiwai@suse.de Date: Wed Jun 20 16:32:22 2012 +0200

 ALSA: hda - Move one-time init codes from generic_hdmi_init()

I'm investigating a kernel panic under kernel 3.5, and I'm not 100% sure (still waiting for person with hw to report back), but the only reasonable explanation I can find is that there is some power management activity going while the repoll timer (for hdmi_present_sense) is running, and that generic_hdmi_init reinitializes the delayed_work struct, thus causing the panic when the timer has elapsed.

If the patch really fixes the issue, then yes, it's worth to send for 3.5 or earlier (if applied cleanly). In that case, better to put more notes about the actual bug you hit (and fixed).

thanks,

Takashi