[alsa-devel] [linux-next:master 10267/11220] sound/soc/codecs/rt5677.c:5246:6: sparse: sparse: symbol 'rt5677_check_hotword' was not declared. Should it be static?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 4e8f108c3af2d6922a64df9f3d3d488c74f6009d commit: 21c00e5df4397870ee835c974bf50570f9d24253 [10267/11220] ASoC: rt5677: Enable jack detect while DSP is running reproduce: # apt-get install sparse # sparse version: v0.6.1-31-gfd3528a-dirty git checkout 21c00e5df4397870ee835c974bf50570f9d24253 make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag Reported-by: kbuild test robot lkp@intel.com
sparse warnings: (new ones prefixed by >>)
sound/soc/codecs/rt5677.c:4700:17: sparse: sparse: dubious: x | !y
sound/soc/codecs/rt5677.c:5246:6: sparse: sparse: symbol 'rt5677_check_hotword' was not declared. Should it be static?
Please review and possibly fold the followup patch.
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
Fixes: 21c00e5df439 ("ASoC: rt5677: Enable jack detect while DSP is running") Signed-off-by: kbuild test robot lkp@intel.com --- rt5677.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index 48955b22262fa..cd01a3a8daa82 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -5243,7 +5243,7 @@ static const struct rt5677_irq_desc rt5677_irq_descs[] = { }, };
-bool rt5677_check_hotword(struct rt5677_priv *rt5677) +static bool rt5677_check_hotword(struct rt5677_priv *rt5677) { int reg_gpio;
On Thu, Nov 14, 2019 at 7:33 AM kbuild test robot lkp@intel.com wrote:
Fixes: 21c00e5df439 ("ASoC: rt5677: Enable jack detect while DSP is running") Signed-off-by: kbuild test robot lkp@intel.com
Acked-by: Curtis Malainey cujomalainey@chromium.org
rt5677.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index 48955b22262fa..cd01a3a8daa82 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -5243,7 +5243,7 @@ static const struct rt5677_irq_desc rt5677_irq_descs[] = { }, };
-bool rt5677_check_hotword(struct rt5677_priv *rt5677) +static bool rt5677_check_hotword(struct rt5677_priv *rt5677) { int reg_gpio;
The patch
ASoC: rt5677: rt5677_check_hotword() can be static
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.5
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From a3b9ed55775eb18ca9f1641f13328f479a3653cb Mon Sep 17 00:00:00 2001
From: kbuild test robot lkp@intel.com Date: Thu, 14 Nov 2019 23:33:04 +0800 Subject: [PATCH] ASoC: rt5677: rt5677_check_hotword() can be static
Fixes: 21c00e5df439 ("ASoC: rt5677: Enable jack detect while DSP is running") Signed-off-by: kbuild test robot lkp@intel.com Link: https://lore.kernel.org/r/20191114153304.n4pyix7qadu76tx4@4978f4969bb8 Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/rt5677.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index f2f763b4c399..e9a051a50ab2 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -5307,7 +5307,7 @@ static const struct rt5677_irq_desc rt5677_irq_descs[] = { }, };
-bool rt5677_check_hotword(struct rt5677_priv *rt5677) +static bool rt5677_check_hotword(struct rt5677_priv *rt5677) { int reg_gpio;
participants (3)
-
Curtis Malainey -
kbuild test robot -
Mark Brown