[alsa-devel] [PATCH] sound: pci: lx6464es: Remove unneeded variable err
This patch fixes below issue reported by coccicheck sound/pci/lx6464es/lx6464es.c:256:5-8: Unneeded variable: "err". Return "0" on line 258
We cannot change return value as its registered with snd_pcm_ops->close
Signed-off-by: Hariprasad Kelam hariprasad.kelam@gmail.com --- sound/pci/lx6464es/lx6464es.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c index 1771a6d..583ca73 100644 --- a/sound/pci/lx6464es/lx6464es.c +++ b/sound/pci/lx6464es/lx6464es.c @@ -253,9 +253,8 @@ static int lx_pcm_open(struct snd_pcm_substream *substream)
static int lx_pcm_close(struct snd_pcm_substream *substream) { - int err = 0; dev_dbg(substream->pcm->card->dev, "->lx_pcm_close\n"); - return err; + return 0; }
static snd_pcm_uframes_t lx_pcm_stream_pointer(struct snd_pcm_substream
On Wed, 10 Jul 2019 04:30:59 +0200, Hariprasad Kelam wrote:
This patch fixes below issue reported by coccicheck sound/pci/lx6464es/lx6464es.c:256:5-8: Unneeded variable: "err". Return "0" on line 258
We cannot change return value as its registered with snd_pcm_ops->close
Signed-off-by: Hariprasad Kelam hariprasad.kelam@gmail.com
Applied, thanks.
Takashi
On Wed, 10 Jul 2019 11:49:31 +0200, Takashi Iwai wrote:
On Wed, 10 Jul 2019 04:30:59 +0200, Hariprasad Kelam wrote:
This patch fixes below issue reported by coccicheck sound/pci/lx6464es/lx6464es.c:256:5-8: Unneeded variable: "err". Return "0" on line 258
We cannot change return value as its registered with snd_pcm_ops->close
Signed-off-by: Hariprasad Kelam hariprasad.kelam@gmail.com
Applied, thanks.
Well, looking at the description above again, I'd drop the text
"We cannot change return value as its registered with snd_pcm_ops->close"
because this is quite misleading. There is absolutely no need for changing the function return type.
thanks,
Takashi
participants (2)
-
Hariprasad Kelam
-
Takashi Iwai