[alsa-devel] [PATCH alsa-plugins] pph: include config.h from rate_speexrate.c
Fixes compilation against libspeexdsp 1.2rc3.
rate_speexrate.c includes speex_resampler.h, which depends on config.h by referencing the HAVE_SPEEX_SPEEXDSP_TYPES_H macro. AFAIK it's not a good idea to include config.h from headers (I don't know/remember why, though), which is why I include config.h from rate_speexrate.c instead of speex_resampler.h.
Signed-off-by: Tanu Kaskinen tanuk@iki.fi --- pph/rate_speexrate.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/pph/rate_speexrate.c b/pph/rate_speexrate.c index 0a1325c..8fc4cef 100644 --- a/pph/rate_speexrate.c +++ b/pph/rate_speexrate.c @@ -28,6 +28,7 @@ POSSIBILITY OF SUCH DAMAGE. */
+#include "config.h" #include <stdio.h> #include <alsa/asoundlib.h> #include <alsa/pcm_rate.h>
On Wed, 27 Jan 2016 12:45:51 +0100, Tanu Kaskinen wrote:
Fixes compilation against libspeexdsp 1.2rc3.
rate_speexrate.c includes speex_resampler.h, which depends on config.h by referencing the HAVE_SPEEX_SPEEXDSP_TYPES_H macro. AFAIK it's not a good idea to include config.h from headers (I don't know/remember why, though), which is why I include config.h from rate_speexrate.c instead of speex_resampler.h.
Signed-off-by: Tanu Kaskinen tanuk@iki.fi
Applied, thanks.
Takashi
pph/rate_speexrate.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/pph/rate_speexrate.c b/pph/rate_speexrate.c index 0a1325c..8fc4cef 100644 --- a/pph/rate_speexrate.c +++ b/pph/rate_speexrate.c @@ -28,6 +28,7 @@ POSSIBILITY OF SUCH DAMAGE. */
+#include "config.h" #include <stdio.h> #include <alsa/asoundlib.h>
#include <alsa/pcm_rate.h>
2.7.0.rc3
participants (2)
-
Takashi Iwai -
Tanu Kaskinen