[alsa-devel] [PATCH 1/1] ASoC: pcm1792a: Remove redundant of_match_ptr helper
'pcm1792a_of_match' is always compiled in. Hence the helper macro is not needed.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org --- sound/soc/codecs/pcm1792a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/pcm1792a.c b/sound/soc/codecs/pcm1792a.c index 7146653a8e16..f4d9b769bcda 100644 --- a/sound/soc/codecs/pcm1792a.c +++ b/sound/soc/codecs/pcm1792a.c @@ -244,7 +244,7 @@ static struct spi_driver pcm1792a_codec_driver = { .driver = { .name = "pcm1792a", .owner = THIS_MODULE, - .of_match_table = of_match_ptr(pcm1792a_of_match), + .of_match_table = pcm1792a_of_match, }, .id_table = pcm1792a_spi_ids, .probe = pcm1792a_spi_probe,
On Sat, Dec 21, 2013 at 01:45:47PM +0530, Sachin Kamat wrote:
'pcm1792a_of_match' is always compiled in. Hence the helper macro is not needed.
Part of the idea here is that the macro drops the reference to the table when OF is not in use and then the table gets eliminated by the compiler as unreferenced so we don't need ifdefs.
Hi
On Sat, Dec 21, 2013 at 3:12 PM, Mark Brown broonie@kernel.org wrote:
On Sat, Dec 21, 2013 at 01:45:47PM +0530, Sachin Kamat wrote:
'pcm1792a_of_match' is always compiled in. Hence the helper macro is not needed.
Part of the idea here is that the macro drops the reference to the table when OF is not in use and then the table gets eliminated by the compiler as unreferenced so we don't need ifdefs.
Yes, I don't understand here why we need to remove. This should go away. BTW I found a bunch of commits from Sanchin on this direction
Michael
participants (3)
-
Mark Brown -
Michael Trimarchi -
Sachin Kamat