Re: [alsa-devel] [PATCH] SM56 Modem in Asus A8J Notebook Series
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
It's a process to merge to the upstream kernel. We need to give a kind of approval from the patch authors and contributors. It consists of a line
ok .. something new for me :-) Here it goes:
Signed-off-by: Christian Rothlaender christian@rothlaender.net
================================================================ hda-codec - patch_si3045.c
This patch adds support for the ASUS A8J Series 56k Modem (Motorola SM56)
Signed-off-by: Christian Rothlaender christian@rothlaender.net
THE PATCH STARTS BELOW ================================================================
Just a small issue is left. With the alsa driver buildin into 2.6.19 slmodem is working, with any newer one (either standalone or buildin driver) we have a "hda-intel: invalid format_val, rate=9600, ch=1, format=2" error in dmesg. Seems something has been broken on that step (probably 1.0.13 to 1.0.14?). Sadly I'm not able to tell right now which alsa was included into 2.6.19. I'm trying to compare the files to get an idea what's wrong (#2799 and #2820 are reporting similar problems).
This should have been fixed in the recent version. The driver dropped the support of 9600HZ accidentally.
That's really good to hear. Can you close the Bug entry #2732 then? (#2799 and #2820 can be closed too, if the 9600 Hz problem is solved)
So thanks a lot ...
Christian
At Fri, 18 May 2007 16:45:40 +0200, Christian Rothländer wrote:
It's a process to merge to the upstream kernel. We need to give a kind of approval from the patch authors and contributors. It consists of a line
ok .. something new for me :-) Here it goes:
Signed-off-by: Christian Rothlaender christian@rothlaender.net
================================================================ hda-codec - patch_si3045.c
This patch adds support for the ASUS A8J Series 56k Modem (Motorola SM56)
Signed-off-by: Christian Rothlaender christian@rothlaender.net
THE PATCH STARTS BELOW
Thanks. I meant 'THE PATCH STARTS BELOW' as to paste the actual patch content there :) Also, the first line is the patch summary, which explains the patch briefly.
Anyway, I applied your patch to ALSA HG tree now. It should be included in the next 1.0.14 (hopefully final) release.
Just a small issue is left. With the alsa driver buildin into 2.6.19 slmodem is working, with any newer one (either standalone or buildin driver) we have a "hda-intel: invalid format_val, rate=9600, ch=1, format=2" error in dmesg. Seems something has been broken on that step (probably 1.0.13 to 1.0.14?). Sadly I'm not able to tell right now which alsa was included into 2.6.19. I'm trying to compare the files to get an idea what's wrong (#2799 and #2820 are reporting similar problems).
This should have been fixed in the recent version. The driver dropped the support of 9600HZ accidentally.
That's really good to hear. Can you close the Bug entry #2732 then? (#2799 and #2820 can be closed too, if the 9600 Hz problem is solved)
OK, will do.
Thanks!
Takashi
participants (2)
-
Christian Rothländer -
Takashi Iwai