On Tue, May 22, 2012 at 1:45 PM, David Daney ddaney.cavm@gmail.com wrote:

On 05/19/2012 11:08 PM, Grant Likely wrote:

...

On Sat, 19 May 2012 23:54:36 -0600, Grant Likelygrant.likely@secretlab.ca  wrote:

...

On Fri, 11 May 2012 15:05:21 -0700, David Daneyddaney.cavm@gmail.com  wrote:

...

From: David Daneydavid.daney@cavium.com

When generating MODALIASes, it is convenient to add things like "spi:" or "i2c:" to the front of the strings.  This allows the standard modprobe to find the right driver when automatically populating bus children from the device tree structure.

Add a prefix parameter, and adjust callers.  For of_register_spi_devices() use the "spi:" prefix.

Signed-off-by: David Daneydavid.daney@cavium.com

Applied, thanks.  Some notes below...

Wait... why is this necessary?

Because in of_register_spi_devices() in of_spi.c, you do:

request_module(spi->modalias);

The string passed to request_module() must have the "spi:" prefix.

How about modifying the call to request_module() to include the prefix also? I think that would be a simpler change overall. Would that work?

g.