[alsa-devel] [PATCH TINYCOMPRESS 4/14] compress: Change running from bitfield to plain int
Declaring running as a single-bit bitfield does not save any space or give any coding advantages, but does leave potential opportunities for the compiler to be inefficient in how it handles bitfields compared to how it would handle a machine int.
diff --git a/compress.c b/compress.c index fa2d43f..c4f215c 100644 --- a/compress.c +++ b/compress.c @@ -82,7 +82,7 @@ struct compress { unsigned int flags; char error[COMPR_ERR_MAX]; struct compr_config *config; - int running:1; + int running; };
static int oops(struct compress *compress, int e, const char *fmt, ...)
Declaring running as a single-bit bitfield does not save any space or give any coding advantages, but does leave potential opportunities for the compiler to be inefficient in how it handles bitfields compared to how it would handle a machine int.
--- compress.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/compress.c b/compress.c index 3cd0f85..d09e161 100644 --- a/compress.c +++ b/compress.c @@ -82,7 +82,7 @@ struct compress { unsigned int flags; char error[COMPR_ERR_MAX]; struct compr_config *config; - unsigned int running:1; + int running; };
static int oops(struct compress *compress, int e, const char *fmt, ...)
participants (1)
-
Richard Fitzgerald