[alsa-devel] [PATCH] ASoC: wm8985: Remove unused pointer in wm8985_remove()
Commit a0b148b4 (ASoC: wm8985: Use devm_regulator_bulk_get()) removed the last user of pointer wm8985 to struct wm8985_priv. Thus remove it. Detected by Coverity CID 1222150.
Signed-off-by: Christian Engelmayer cengelma@gmx.at --- Compile tested. Applies against branch for-next in tree git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git --- sound/soc/codecs/wm8985.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/sound/soc/codecs/wm8985.c b/sound/soc/codecs/wm8985.c index 0f5780c..cbbdfbb 100644 --- a/sound/soc/codecs/wm8985.c +++ b/sound/soc/codecs/wm8985.c @@ -980,9 +980,6 @@ static int wm8985_resume(struct snd_soc_codec *codec)
static int wm8985_remove(struct snd_soc_codec *codec) { - struct wm8985_priv *wm8985; - - wm8985 = snd_soc_codec_get_drvdata(codec); wm8985_set_bias_level(codec, SND_SOC_BIAS_OFF); return 0; }
On Fri, Jun 13, 2014 at 07:19:28PM +0200, Christian Engelmayer wrote:
Commit a0b148b4 (ASoC: wm8985: Use devm_regulator_bulk_get()) removed the last user of pointer wm8985 to struct wm8985_priv. Thus remove it. Detected by Coverity CID 1222150.
Signed-off-by: Christian Engelmayer cengelma@gmx.at
Acked-by: Charles Keepax ckeepax@opensource.wolfsonmicro.com
Thanks, Charles
participants (3)
-
Charles Keepax
-
Christian Engelmayer
-
Mark Brown