[alsa-devel] [PATCH v2] ASoC: imx-ssi: Remove mono support
From: Fabio Estevam fabio.estevam@freescale.com
Playing a mono track results in incorrect playback rate, ie, the audio is played at a faster rate.
Remove mono support in the driver by setting 'channes_min' to dual-channel and this allows mono tracks to be played correctly.
Reported-by: Gaëtan Carlier gcembed@gmail.com Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- Changes since v1: - Also change 'channels_min' for the capture - Improve the commit log sound/soc/fsl/imx-ssi.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c index 3c520c4..7074ae6 100644 --- a/sound/soc/fsl/imx-ssi.c +++ b/sound/soc/fsl/imx-ssi.c @@ -380,13 +380,14 @@ static int imx_ssi_dai_probe(struct snd_soc_dai *dai) static struct snd_soc_dai_driver imx_ssi_dai = { .probe = imx_ssi_dai_probe, .playback = { - .channels_min = 1, + /* The SSI does not support monaural audio. */ + .channels_min = 2, .channels_max = 2, .rates = SNDRV_PCM_RATE_8000_96000, .formats = SNDRV_PCM_FMTBIT_S16_LE, }, .capture = { - .channels_min = 1, + .channels_min = 2, .channels_max = 2, .rates = SNDRV_PCM_RATE_8000_96000, .formats = SNDRV_PCM_FMTBIT_S16_LE,
Hi,
On 08/07/2012 09:51 PM, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
Playing a mono track results in incorrect playback rate, ie, the audio is played at a faster rate.
Remove mono support in the driver by setting 'channes_min' to dual-channel and this allows mono tracks to be played correctly.
Reported-by: Gaëtan Carlier gcembed@gmail.com Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Changes since v1:
- Also change 'channels_min' for the capture
- Improve the commit log sound/soc/fsl/imx-ssi.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c index 3c520c4..7074ae6 100644 --- a/sound/soc/fsl/imx-ssi.c +++ b/sound/soc/fsl/imx-ssi.c @@ -380,13 +380,14 @@ static int imx_ssi_dai_probe(struct snd_soc_dai *dai) static struct snd_soc_dai_driver imx_ssi_dai = { .probe = imx_ssi_dai_probe, .playback = {
.channels_min = 1,
/* The SSI does not support monaural audio. */
.channels_max = 2, .rates = SNDRV_PCM_RATE_8000_96000, .formats = SNDRV_PCM_FMTBIT_S16_LE, }, .capture = {.channels_min = 2,
.channels_min = 1,
.channels_max = 2, .rates = SNDRV_PCM_RATE_8000_96000, .formats = SNDRV_PCM_FMTBIT_S16_LE,.channels_min = 2,
On imx27_3ds board:
Tested-by: Gaëtan Carlier gcembed@gmail.com
Regards, Gaëtan Carlier
On Tue, Aug 07, 2012 at 04:51:34PM -0300, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
Playing a mono track results in incorrect playback rate, ie, the audio is played at a faster rate.
Applied, thanks.
participants (3)
-
Fabio Estevam
-
Gaëtan Carlier
-
Mark Brown