Re: [PATCH 6/6] i2c: Make remove callback return void
On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote:
From: Uwe Kleine-König uwe@kleine-koenig.org
The value returned by an i2c driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.)
So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before.
Signed-off-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de
Assuming you remove the spurious kasan change:
Reviewed-by: Vladimir Oltean olteanv@gmail.com
On Wed, Jul 06, 2022 at 12:13:15PM +0300, Vladimir Oltean wrote:
On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote:
From: Uwe Kleine-König uwe@kleine-koenig.org
The value returned by an i2c driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.)
So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before.
Signed-off-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de
Assuming you remove the spurious kasan change:
It's already gone in my tree, see https://git.pengutronix.de/cgit/ukl/linux/commit/?h=i2c-remove-void
Reviewed-by: Vladimir Oltean olteanv@gmail.com
Thanks Uwe
participants (2)
-
Uwe Kleine-König -
Vladimir Oltean