Re: [PATCH 2/2] ASoC: wm8961: add support for devicetree
On 10/1/2022 3:23 PM, kernel test robot wrote:
sound/soc/codecs/wm8961.c:974:34: warning: 'wm8961_of_match' defined but not used [-Wunused-const-variable=]
974 | static const struct of_device_id wm8961_of_match[] = { | ^~~~~~~~~~~~~~~
Oops, nice catch by the kernel test robot. I will submit a V2 patch that does this part exactly how the wm8960 driver does it, including .of_match_table in wm8961_i2c_driver. Waiting to see if I get any other feedback on V1 first.
Thanks, Doug
On 02/10/2022 07:04, Doug Brown wrote:
On 10/1/2022 3:23 PM, kernel test robot wrote:
sound/soc/codecs/wm8961.c:974:34: warning: 'wm8961_of_match' defined but not used [-Wunused-const-variable=]
974 | static const struct of_device_id wm8961_of_match[] = { | ^~~~~~~~~~~~~~~Oops, nice catch by the kernel test robot. I will submit a V2 patch that
Now I see the report about issue I wrote to you. It's not particular nice catch of robot... it's visible from the code and easily testable by yourself. Even without compile test... The code was just not tested for warnings.
does this part exactly how the wm8960 driver does it, including .of_match_table in wm8961_i2c_driver. Waiting to see if I get any other feedback on V1 first.
maybe_unused instead of ifdefs.
Best regards, Krzysztof
Hi Krzysztof,
On 10/2/2022 1:35 AM, Krzysztof Kozlowski wrote:
Now I see the report about issue I wrote to you. It's not particular nice catch of robot... it's visible from the code and easily testable by yourself. Even without compile test... The code was just not tested for warnings.
Thanks for your thorough and timely review. It is much appreciated. I will address everything you mentioned in V2, and will do a better job of checking for warnings with multiple configs going forward.
Doug
participants (2)
-
Doug Brown -
Krzysztof Kozlowski