[alsa-devel] [PATCH v3 0/7] ACPICA: Enable ACPICA prototypes for CONFIG_ACPI=n builds.
v3: PATCH 3/7 updated to remove new Kconfig item.
This is the last series for ACPICA header inclusion cleanups. The whole story can be found below: 1. Unsafe inclusions: origin: https://lkml.org/lkml/2013/11/22/510 merged: https://lkml.org/lkml/2013/12/6/79 2. Header orders: origin: https://lkml.org/lkml/2014/4/8/57 merged: https://lkml.org/lkml/2014/5/12/111 3. Header stubs: origin: https://lkml.org/lkml/2014/12/18/149 merged: https://lkml.org/lkml/2014/4/29/716
This patchset contains patches that are parts of the last series sent before, so it is marked as v2 belonging to the same thread as this series: https://lkml.org/lkml/2014/12/18/149
Now we have cleaned up all mis-ordered ACPICA headers and implemented stubs for ACPICA prototypes (functions, global variables, macros), we finally can enable ACPICA headers for CONFIG_ACPI=n builds so that all ACPICA defined types are visible to all kernel source files.
After exposing ACPICA types to all kernel sources, we can also sort the final wrong <acpi/acpi.h> inclusion out of <linux/sfi_acpi.h>.
This patchset also includes a rule enforcement patch to avoid future inclusion mistakes.
The patch set has passed a build/boot test on the following machines: Dell Inspiron Mini 1010 (i386) HP Compaq 8200 Elite SFF PC (x86-64) With the following kernel configuration items enabled: All drivers/acpi configurations All platform drivers All ACPI drivers 4 DRM drivers that implement ACPI opregion All buses with ACPI bindings All cpufreq configurations All xen configurations All ACPI table drivers They are tested twice with CONFIG_ACPI enabled/disabled.
Also allyes/allno/allmod tests are done for ARCH=i386 and ARCH=x86_64.
A boot test has been done to ARCH=x86_64 default configuration and it is confirmed that the ACPI devices are successfully created under /sys/bus/acpi/devices when CONFIG_ACPI is enabled.
Lv Zheng (7): ACPICA: Linux: Add stub support for Linux specific variables and functions. ACPICA: Linux: Add stub implementation of ACPICA 64-bit mathematics. ACPICA: Linux: Add support to exclude <asm/acenv.h> inclusion. ACPICA: Linux: Allow ACPICA inclusion for CONFIG_ACPI=n builds. ACPI/SFI: Fix wrong <acpi/acpi.h> inclusion in SFI/ACPI wrapper - table definitions. ACPI: Add support to force header inclusion rules for <acpi/acpi.h>. ACPI: Cleanup useless ACPI inclusion.
arch/ia64/include/asm/acenv.h | 4 ---- arch/x86/include/asm/acenv.h | 4 ---- drivers/acpi/acpica/Makefile | 2 +- drivers/acpi/bus.c | 3 --- include/acpi/acpixf.h | 28 +++++++++++++++++----------- include/acpi/platform/aclinux.h | 12 ++++++++++++ include/acpi/platform/aclinuxex.h | 22 ++++++++++++++++++++++ include/linux/acpi.h | 6 +++--- include/linux/sfi_acpi.h | 3 --- sound/soc/intel/sst-haswell-dsp.c | 3 --- 10 files changed, 55 insertions(+), 32 deletions(-)
The sst-haswell-dsp.c is an ACPI independent file, this patch removes ACPI header files for it.
Signed-off-by: Lv Zheng lv.zheng@intel.com Cc: Liam Girdwood lgirdwood@gmail.com Cc: Mark Brown broonie@kernel.org Cc: alsa-devel@alsa-project.org --- sound/soc/intel/sst-haswell-dsp.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/sound/soc/intel/sst-haswell-dsp.c b/sound/soc/intel/sst-haswell-dsp.c index 535f517..ecc5057 100644 --- a/sound/soc/intel/sst-haswell-dsp.c +++ b/sound/soc/intel/sst-haswell-dsp.c @@ -28,9 +28,6 @@ #include <linux/firmware.h> #include <linux/pm_runtime.h>
-#include <linux/acpi.h> -#include <acpi/acpi_bus.h> - #include "sst-dsp.h" #include "sst-dsp-priv.h" #include "sst-haswell-ipc.h"
On Wed, Jul 16, 2014 at 04:59:02PM +0800, Lv Zheng wrote:
The sst-haswell-dsp.c is an ACPI independent file, this patch removes ACPI header files for it.
Applied, thanks. Please use subject lines matching the style for the subsystem and send at least the cover letter for the series to everyone so that they know what's going on with dependencies and so on.
On Wednesday, July 16, 2014 01:07:50 PM Mark Brown wrote:
--5me2qT3T17SWzdxI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline
On Wed, Jul 16, 2014 at 04:59:02PM +0800, Lv Zheng wrote:
The sst-haswell-dsp.c is an ACPI independent file, this patch removes ACPI header files for it.
Applied, thanks. Please use subject lines matching the style for the subsystem and send at least the cover letter for the series to everyone so that they know what's going on with dependencies and so on.
Lv thought that this would go through the ACPI tree I suppose.
Rafael
On Wed, Jul 16, 2014 at 11:46:14PM +0200, Rafael J. Wysocki wrote:
On Wednesday, July 16, 2014 01:07:50 PM Mark Brown wrote:
On Wed, Jul 16, 2014 at 04:59:02PM +0800, Lv Zheng wrote:
The sst-haswell-dsp.c is an ACPI independent file, this patch removes ACPI header files for it.
Applied, thanks. Please use subject lines matching the style for the subsystem and send at least the cover letter for the series to everyone so that they know what's going on with dependencies and so on.
Lv thought that this would go through the ACPI tree I suppose.
Even so the subject line should still line up (it's part of how some of us pick out which mail to read).
Hi,
From: Mark Brown [mailto:broonie@kernel.org] Sent: Thursday, July 17, 2014 5:35 AM
On Wed, Jul 16, 2014 at 11:46:14PM +0200, Rafael J. Wysocki wrote:
On Wednesday, July 16, 2014 01:07:50 PM Mark Brown wrote:
On Wed, Jul 16, 2014 at 04:59:02PM +0800, Lv Zheng wrote:
The sst-haswell-dsp.c is an ACPI independent file, this patch removes ACPI header files for it.
Applied, thanks. Please use subject lines matching the style for the subsystem and send at least the cover letter for the series to everyone so that they know what's going on with dependencies and so on.
Lv thought that this would go through the ACPI tree I suppose.
Even so the subject line should still line up (it's part of how some of us pick out which mail to read).
I just didn't notice this. :-) I'll take care next time.
Thanks and best regards -Lv
participants (4)
-
Lv Zheng -
Mark Brown -
Rafael J. Wysocki -
Zheng, Lv