Hi Mark Brown

Thank you for your valuable advice to let me understand the problem. I will fix this issue in the next patch

Best regards Weidong Wang

On Mon, Oct 24, 2022 at 10:41:03AM +0800, wangweidong.a@awinic.com wrote:

...

Then it's not a mute function, the goal of the mute function is to run

before all the power management code to minimise glitches during power management. Just implement the power management via the standard ASoC power

...

management APIs.

The essence of calling mute is not switch dsp, but switch PA. We think that PA has only two states. When no audio stream enters, turn off the PA and turn off the PA's dsp. When the audio stream enters, the PA is turned on, and the dsp is turned on at the same time

That's not what the mute function is for, the interface is specifically

for muting the stream while power management changes are

going on. What you're describing is power management so should be

controlled via DAPM.

If your device doesn't have any support for a separate mute function then

it should just not implement anything for that in the

driver.