[alsa-devel] [PATCH 0/1] hdsp - Provide ioctl_compat
Hi,
short patch to provide ioctl_compat for HDSP cards as well. Quick test with SNDRV_HDSPM_IOCTL_GET_PEAK_RMS worked. Please review and apply. Thanks!
Cheers, Andre
snd_hdsp uses its own ioctls to acquire config- and status information. Expose the corresponding ioctl handler via ioctl_compat, so that 32bit applications can use it on 64bit kernels.
Signed-off-by: Andre Schramm andre.schramm@iosono-sound.com
diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c index 5cc31a4..0d6930c 100644 --- a/sound/pci/rme9652/hdsp.c +++ b/sound/pci/rme9652/hdsp.c @@ -5170,6 +5170,7 @@ static int snd_hdsp_create_hwdep(struct snd_card *card, struct hdsp *hdsp) strcpy(hw->name, "HDSP hwdep interface");
hw->ops.ioctl = snd_hdsp_hwdep_ioctl; + hw->ops.ioctl_compat = snd_hdsp_hwdep_ioctl;
return 0; }
From: Andre Schramm andre.schramm@iosono-sound.com
snd_hdsp uses its own ioctls to acquire config- and status information. Expose the corresponding ioctl handler via ioctl_compat, so that 32bit applications can use it on 64bit kernels.
Signed-off-by: Andre Schramm andre.schramm@iosono-sound.com Reviewed-by: Adrian Knoth adi@drcomp.erfurt.thur.de Signed-off-by: Adrian Knoth adi@drcomp.erfurt.thur.de
diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c index 5cc31a4..0d6930c 100644 --- a/sound/pci/rme9652/hdsp.c +++ b/sound/pci/rme9652/hdsp.c @@ -5170,6 +5170,7 @@ static int snd_hdsp_create_hwdep(struct snd_card *card, struct hdsp *hdsp) strcpy(hw->name, "HDSP hwdep interface");
hw->ops.ioctl = snd_hdsp_hwdep_ioctl; + hw->ops.ioctl_compat = snd_hdsp_hwdep_ioctl;
return 0; }
On Mon, May 07, 2012 at 06:52:51PM +0200, Adrian Knoth wrote:
From: Andre Schramm andre.schramm@iosono-sound.com
snd_hdsp uses its own ioctls to acquire config- and status information. Expose the corresponding ioctl handler via ioctl_compat, so that 32bit applications can use it on 64bit kernels.
Signed-off-by: Andre Schramm andre.schramm@iosono-sound.com Reviewed-by: Adrian Knoth adi@drcomp.erfurt.thur.de Signed-off-by: Adrian Knoth adi@drcomp.erfurt.thur.de
The last line wasn't supposed to be there, feel free to drop it.
Sorry for the noise, copy&paste error.
Mea culpa
At Mon, 7 May 2012 18:55:04 +0200, Adrian Knoth wrote:
On Mon, May 07, 2012 at 06:52:51PM +0200, Adrian Knoth wrote:
From: Andre Schramm andre.schramm@iosono-sound.com
snd_hdsp uses its own ioctls to acquire config- and status information. Expose the corresponding ioctl handler via ioctl_compat, so that 32bit applications can use it on 64bit kernels.
Signed-off-by: Andre Schramm andre.schramm@iosono-sound.com Reviewed-by: Adrian Knoth adi@drcomp.erfurt.thur.de Signed-off-by: Adrian Knoth adi@drcomp.erfurt.thur.de
The last line wasn't supposed to be there, feel free to drop it.
It's correct that you add your sign-off when you submit the patch. So, don't worry about that.
Now applied to sound git tree.
Thanks for poking this. I was on vacation in the last week and seem to have missed some patches.
Takashi
participants (3)
-
Adrian Knoth -
Andre Schramm -
Takashi Iwai