[PATCH 1/2] dt-bindings: panel: ili9341: correct indentation
Correct indentation warning: ilitek,ili9341.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@canonical.com --- .../devicetree/bindings/display/panel/ilitek,ili9341.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml index 2ed010f91e2d..20ce88ab4b3a 100644 --- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml @@ -22,7 +22,7 @@ properties: items: - enum: # ili9341 240*320 Color on stm32f429-disco board - - st,sf-tc240t-9370-t + - st,sf-tc240t-9370-t - const: ilitek,ili9341
reg: true
Use common enum instead of oneOf and correct indentation warning: realtek,rt1015p.yaml:18:7: [warning] wrong indentation: expected 4 but found 6 (indentation)
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@canonical.com --- .../devicetree/bindings/sound/realtek,rt1015p.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt1015p.yaml b/Documentation/devicetree/bindings/sound/realtek,rt1015p.yaml index f31d3c4d0192..fdb7f295ef2d 100644 --- a/Documentation/devicetree/bindings/sound/realtek,rt1015p.yaml +++ b/Documentation/devicetree/bindings/sound/realtek,rt1015p.yaml @@ -15,9 +15,9 @@ description: |
properties: compatible: - oneOf: - - const: realtek,rt1015p - - const: realtek,rt1019p + enum: + - realtek,rt1015p + - realtek,rt1019p
sdb-gpios: description:
On Thu, Aug 19, 2021 at 5:12 AM Krzysztof Kozlowski krzysztof.kozlowski@canonical.com wrote:
Use common enum instead of oneOf and correct indentation warning: realtek,rt1015p.yaml:18:7: [warning] wrong indentation: expected 4 but found 6 (indentation)
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@canonical.com
.../devicetree/bindings/sound/realtek,rt1015p.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Acked-by: Rob Herring robh@kernel.org
On Thu, Aug 19, 2021 at 04:52:38PM -0500, Rob Herring wrote:
On Thu, Aug 19, 2021 at 5:12 AM Krzysztof Kozlowski krzysztof.kozlowski@canonical.com wrote:
Use common enum instead of oneOf and correct indentation warning: realtek,rt1015p.yaml:18:7: [warning] wrong indentation: expected 4 but found 6 (indentation)
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@canonical.com
Acked-by: Rob Herring robh@kernel.org
Acked-by: Tzung-Bi Shih tzungbi@google.com
On Thu, Aug 19, 2021 at 12:10:20PM +0200, Krzysztof Kozlowski wrote:
Use common enum instead of oneOf and correct indentation warning: realtek,rt1015p.yaml:18:7: [warning] wrong indentation: expected 4 but found 6 (indentation)
For stuff like this where there's no relationship between the things being patched it's probably better to just send a bunch of individual patches rather than a series, it works better with tooling and makes it clear there's no interdependencies or anything.
Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
On Thu, 19 Aug 2021 12:10:19 +0200, Krzysztof Kozlowski wrote:
Correct indentation warning: ilitek,ili9341.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[2/2] dt-bindings: sound: rt1015p: correct indentation commit: 0aeb17d1728257f29131a290f0cc8e281cc7274c
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
Hi Mark,
On Mon, Aug 23, 2021 at 06:37:55PM +0100, Mark Brown wrote:
On Thu, 19 Aug 2021 12:10:19 +0200, Krzysztof Kozlowski wrote:
Correct indentation warning: ilitek,ili9341.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[2/2] dt-bindings: sound: rt1015p: correct indentation commit: 0aeb17d1728257f29131a290f0cc8e281cc7274c
I am confused here. Did you apply both patches or only the one touching sound?
I will pick up the panel patch otherwise.
Sam
On Mon, Aug 23, 2021 at 09:38:56PM +0200, Sam Ravnborg wrote:
On Mon, Aug 23, 2021 at 06:37:55PM +0100, Mark Brown wrote:
[2/2] dt-bindings: sound: rt1015p: correct indentation commit: 0aeb17d1728257f29131a290f0cc8e281cc7274c
I am confused here. Did you apply both patches or only the one touching sound?
I will pick up the panel patch otherwise.
Only the second patch, it's the only one listed above and the subject says subset.
On Thu, Aug 19, 2021 at 12:10:19PM +0200, Krzysztof Kozlowski wrote:
Correct indentation warning: ilitek,ili9341.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@canonical.com
Thanks, applied to drm-misc-next, and the patch will show up in -next in one to two weeks.
Sam
On Mon, Aug 23, 2021 at 3:11 PM Sam Ravnborg sam@ravnborg.org wrote:
On Thu, Aug 19, 2021 at 12:10:19PM +0200, Krzysztof Kozlowski wrote:
Correct indentation warning: ilitek,ili9341.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@canonical.com
Thanks, applied to drm-misc-next, and the patch will show up in -next in one to two weeks.
This needs to go in fixes as it looks like commit 7dbdce806268 ("dt-bindings: display: panel: Add ilitek ili9341 panel bindings") is queued for 5.15.
Rob
participants (5)
-
Krzysztof Kozlowski -
Mark Brown -
Rob Herring -
Sam Ravnborg -
Tzung-Bi Shih