[alsa-devel] [PATCH -next] ASoC: Intel: sst_hsw: remove kfree for memory allocated with devm_kzalloc
From: Wei Yongjun yongjun_wei@trendmicro.com.cn
It's not necessary to free memory allocated with devm_kzalloc and using kfree leads to a double free.
Signed-off-by: Wei Yongjun yongjun_wei@trendmicro.com.cn --- sound/soc/intel/haswell/sst-haswell-ipc.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/intel/haswell/sst-haswell-ipc.c b/sound/soc/intel/haswell/sst-haswell-ipc.c index 344a1e9..324eceb 100644 --- a/sound/soc/intel/haswell/sst-haswell-ipc.c +++ b/sound/soc/intel/haswell/sst-haswell-ipc.c @@ -2201,7 +2201,6 @@ dma_err: dsp_new_err: sst_ipc_fini(ipc); ipc_init_err: - kfree(hsw); return ret; } EXPORT_SYMBOL_GPL(sst_hsw_dsp_init);
On 04/16/2015 04:46 PM, weiyj_lk@163.com wrote:
From: Wei Yongjun yongjun_wei@trendmicro.com.cn
It's not necessary to free memory allocated with devm_kzalloc and using kfree leads to a double free.
Signed-off-by: Wei Yongjun yongjun_wei@trendmicro.com.cn
sound/soc/intel/haswell/sst-haswell-ipc.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/intel/haswell/sst-haswell-ipc.c b/sound/soc/intel/haswell/sst-haswell-ipc.c index 344a1e9..324eceb 100644 --- a/sound/soc/intel/haswell/sst-haswell-ipc.c +++ b/sound/soc/intel/haswell/sst-haswell-ipc.c @@ -2201,7 +2201,6 @@ dma_err: dsp_new_err: sst_ipc_fini(ipc); ipc_init_err:
- kfree(hsw); return ret; } EXPORT_SYMBOL_GPL(sst_hsw_dsp_init);
Similar case than with baytrail. Here introduced by commit 0e7921e9583b ("ASoC: Intel: Use the generic IPC/mailbox APIs in Broadwell")
Reviewed-by: Jarkko Nikula jarkko.nikula@linux.intel.com
For HSW, a patch "[PATCH] ASoC: Intel: Remove invalid kfree of devm allocated data" to fix this issue has been applied.
But yes, we also need a similar patch for Baytrail.
Thanks Jin Yao
On 2015/4/16 22:08, Jarkko Nikula wrote:
On 04/16/2015 04:46 PM, weiyj_lk@163.com wrote:
From: Wei Yongjun yongjun_wei@trendmicro.com.cn
It's not necessary to free memory allocated with devm_kzalloc and using kfree leads to a double free.
Signed-off-by: Wei Yongjun yongjun_wei@trendmicro.com.cn
sound/soc/intel/haswell/sst-haswell-ipc.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/intel/haswell/sst-haswell-ipc.c b/sound/soc/intel/haswell/sst-haswell-ipc.c index 344a1e9..324eceb 100644 --- a/sound/soc/intel/haswell/sst-haswell-ipc.c +++ b/sound/soc/intel/haswell/sst-haswell-ipc.c @@ -2201,7 +2201,6 @@ dma_err: dsp_new_err: sst_ipc_fini(ipc); ipc_init_err:
- kfree(hsw); return ret; } EXPORT_SYMBOL_GPL(sst_hsw_dsp_init);
Similar case than with baytrail. Here introduced by commit 0e7921e9583b ("ASoC: Intel: Use the generic IPC/mailbox APIs in Broadwell")
Reviewed-by: Jarkko Nikula jarkko.nikula@linux.intel.com _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
On Thu, Apr 16, 2015 at 09:46:18PM +0800, weiyj_lk@163.com wrote:
From: Wei Yongjun yongjun_wei@trendmicro.com.cn
It's not necessary to free memory allocated with devm_kzalloc and using kfree leads to a double free.
Like Yao said a fix for this has already been applied.
participants (4)
-
Jarkko Nikula -
Jin, Yao -
Mark Brown -
weiyj_lk＠163.com