[alsa-devel] [PATCH 1/3] rcar: ctu: Avoid use of ret uninitialised
We use ret as the return value from the rsnd_ctu_probe() but if there are no child nodes and no errors then we will never initialize ret leading to build warnings. Ensure ret is initialized before we iterate over the child nodes to avoid this.
Signed-off-by: Mark Brown broonie@kernel.org ---
Perhaps this should be an error instead? It's not like it's a sensible configuration...
sound/soc/sh/rcar/ctu.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/sh/rcar/ctu.c b/sound/soc/sh/rcar/ctu.c index 7c1e190cd389..d53a225d19e9 100644 --- a/sound/soc/sh/rcar/ctu.c +++ b/sound/soc/sh/rcar/ctu.c @@ -111,6 +111,7 @@ int rsnd_ctu_probe(struct rsnd_priv *priv) priv->ctu = ctu;
i = 0; + ret = 0; for_each_child_of_node(node, np) { ctu = rsnd_ctu_get(priv, i);
We use ret as the return value from the rsnd_dvc_probe() but if there are no child nodes and no errors then we will never initialize ret leading to build warnings. Ensure ret is initialized before we iterate over the child nodes to avoid this.
Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/sh/rcar/dvc.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/sh/rcar/dvc.c b/sound/soc/sh/rcar/dvc.c index 66aeea8e0069..42e6a230a3d1 100644 --- a/sound/soc/sh/rcar/dvc.c +++ b/sound/soc/sh/rcar/dvc.c @@ -360,6 +360,7 @@ int rsnd_dvc_probe(struct rsnd_priv *priv) priv->dvc = dvc;
i = 0; + ret = 0; for_each_child_of_node(node, np) { dvc = rsnd_dvc_get(priv, i);
The patch
rcar: dvc: Avoid use of ret uninitialised
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 2e4118dac3d6765186dd1faf1fd3cede37b74e73 Mon Sep 17 00:00:00 2001
From: Mark Brown broonie@kernel.org Date: Mon, 14 Dec 2015 12:05:17 +0000 Subject: [PATCH] rcar: dvc: Avoid use of ret uninitialised
We use ret as the return value from the rsnd_dvc_probe() but if there are no child nodes and no errors then we will never initialize ret leading to build warnings. Ensure ret is initialized before we iterate over the child nodes to avoid this.
Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/sh/rcar/dvc.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/sh/rcar/dvc.c b/sound/soc/sh/rcar/dvc.c index 66aeea8e0069..42e6a230a3d1 100644 --- a/sound/soc/sh/rcar/dvc.c +++ b/sound/soc/sh/rcar/dvc.c @@ -360,6 +360,7 @@ int rsnd_dvc_probe(struct rsnd_priv *priv) priv->dvc = dvc;
i = 0; + ret = 0; for_each_child_of_node(node, np) { dvc = rsnd_dvc_get(priv, i);
We use ret as the return value from the rsnd_mix_probe() but if there are no child nodes and no errors then we will never initialize ret leading to build warnings. Ensure ret is initialized before we iterate over the child nodes to avoid this.
Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/sh/rcar/mix.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/sh/rcar/mix.c b/sound/soc/sh/rcar/mix.c index b34957ab75b9..65542b6a89e9 100644 --- a/sound/soc/sh/rcar/mix.c +++ b/sound/soc/sh/rcar/mix.c @@ -158,6 +158,7 @@ int rsnd_mix_probe(struct rsnd_priv *priv) priv->mix = mix;
i = 0; + ret = 0; for_each_child_of_node(node, np) { mix = rsnd_mix_get(priv, i);
The patch
rcar: mux: Avoid use of ret uninitialised
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 2b235a3da5560d65df6865ea436389e55a0f41ad Mon Sep 17 00:00:00 2001
From: Mark Brown broonie@kernel.org Date: Mon, 14 Dec 2015 12:05:28 +0000 Subject: [PATCH] rcar: mux: Avoid use of ret uninitialised
We use ret as the return value from the rsnd_mix_probe() but if there are no child nodes and no errors then we will never initialize ret leading to build warnings. Ensure ret is initialized before we iterate over the child nodes to avoid this.
Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/sh/rcar/mix.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/sh/rcar/mix.c b/sound/soc/sh/rcar/mix.c index b34957ab75b9..65542b6a89e9 100644 --- a/sound/soc/sh/rcar/mix.c +++ b/sound/soc/sh/rcar/mix.c @@ -158,6 +158,7 @@ int rsnd_mix_probe(struct rsnd_priv *priv) priv->mix = mix;
i = 0; + ret = 0; for_each_child_of_node(node, np) { mix = rsnd_mix_get(priv, i);
Hi Mark
We use ret as the return value from the rsnd_ctu_probe() but if there are no child nodes and no errors then we will never initialize ret leading to build warnings. Ensure ret is initialized before we iterate over the child nodes to avoid this.
Signed-off-by: Mark Brown broonie@kernel.org
I didn't notice about this issue. Thanks
Perhaps this should be an error instead? It's not like it's a sensible configuration...
No DVC, No CTU, No MIX are not error in my opinion.
Acked-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
Hi Mark again
We use ret as the return value from the rsnd_ctu_probe() but if there are no child nodes and no errors then we will never initialize ret leading to build warnings. Ensure ret is initialized before we iterate over the child nodes to avoid this.
Signed-off-by: Mark Brown broonie@kernel.org
This is just comment. It will return 0 if there is no child nodes
node = rsnd_ctu_of_node(priv); if (!node) return 0; /* not used is not error */ ...
for_each_child_of_node(node, np) { ...
The patch
rcar: ctu: Avoid use of ret uninitialised
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 76ca9970322118610681af5f929aba62f346082b Mon Sep 17 00:00:00 2001
From: Mark Brown broonie@kernel.org Date: Mon, 14 Dec 2015 12:04:54 +0000 Subject: [PATCH] rcar: ctu: Avoid use of ret uninitialised
We use ret as the return value from the rsnd_ctu_probe() but if there are no child nodes and no errors then we will never initialize ret leading to build warnings. Ensure ret is initialized before we iterate over the child nodes to avoid this.
Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/sh/rcar/ctu.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/sh/rcar/ctu.c b/sound/soc/sh/rcar/ctu.c index 7c1e190cd389..d53a225d19e9 100644 --- a/sound/soc/sh/rcar/ctu.c +++ b/sound/soc/sh/rcar/ctu.c @@ -111,6 +111,7 @@ int rsnd_ctu_probe(struct rsnd_priv *priv) priv->ctu = ctu;
i = 0; + ret = 0; for_each_child_of_node(node, np) { ctu = rsnd_ctu_get(priv, i);
participants (2)
-
Kuninori Morimoto -
Mark Brown