On 9/9/2020 1:55 PM, Keith Busch wrote:

On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote:

...

diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index eea0f453cfb6..8aac5bc60f4c 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c @@ -2464,7 +2464,7 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb) test_hash_speed("streebog512", sec, generic_hash_speed_template); if (mode > 300 && mode < 400) break;

• fallthrough;
  

• break;
  

  case 399: break;

Just imho, this change makes the preceding 'if' look even more pointless. Maybe the fallthrough was a deliberate choice? Not that my opinion matters here as I don't know this module, but it looked a bit odd to me.

Yea this does look very odd..