[alsa-devel] [PATCH][Trivial] Delete trailing whitespace from sound/soc/codecs/wm8994.c
While reading through sound/soc/codecs/wm8994.c I noticed a fair amount of trailing whitespace. This patch gets rid of it.
Signed-off-by: Jesper Juhl jj@chaosbits.net --- sound/soc/codecs/wm8994.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c index 7c49642..c6c2cb2 100644 --- a/sound/soc/codecs/wm8994.c +++ b/sound/soc/codecs/wm8994.c @@ -398,7 +398,7 @@ static void wm8994_set_retune_mobile(struct snd_soc_codec *codec, int block) wm8994->dac_rates[iface]);
/* The EQ will be disabled while reconfiguring it, remember the - * current configuration. + * current configuration. */ save = snd_soc_read(codec, base); save &= WM8994_AIF1DAC1_EQ_ENA; @@ -991,7 +991,7 @@ static void wm8994_update_class_w(struct snd_soc_codec *codec) WM8994_CP_DYN_SRC_SEL_MASK, source | WM8994_CP_DYN_PWR); wm8994->hubs.class_w = true; - + } else { dev_dbg(codec->dev, "Class W disabled\n"); snd_soc_update_bits(codec, WM8994_CLASS_W_1, @@ -1358,7 +1358,7 @@ static const struct snd_kcontrol_new wm8958_aif3adc_mux = SOC_DAPM_ENUM("AIF3ADC Mux", wm8958_aif3adc_enum);
static const char *mono_pcm_out_text[] = { - "None", "AIF2ADCL", "AIF2ADCR", + "None", "AIF2ADCL", "AIF2ADCR", };
static const struct soc_enum mono_pcm_out_enum = @@ -2122,7 +2122,7 @@ static int wm8994_set_dai_sysclk(struct snd_soc_dai *dai,
case WM8994_SYSCLK_OPCLK: /* Special case - a division (times 10) is given and - * no effect on main clocking. + * no effect on main clocking. */ if (freq) { for (i = 0; i < ARRAY_SIZE(opclk_divs); i++) @@ -2958,14 +2958,14 @@ static void wm8994_handle_retune_mobile_pdata(struct wm8994_priv *wm8994)
/* Expand the array... */ t = krealloc(wm8994->retune_mobile_texts, - sizeof(char *) * + sizeof(char *) * (wm8994->num_retune_mobile_texts + 1), GFP_KERNEL); if (t == NULL) continue;
/* ...store the new entry... */ - t[wm8994->num_retune_mobile_texts] = + t[wm8994->num_retune_mobile_texts] = pdata->retune_mobile_cfgs[i].name;
/* ...and remember the new version. */ @@ -3907,7 +3907,6 @@ static int wm8994_codec_probe(struct snd_soc_codec *codec) ARRAY_SIZE(wm8994_dac_widgets)); break; } -
wm_hubs_add_analogue_routes(codec, 0, 0); snd_soc_dapm_add_routes(dapm, intercon, ARRAY_SIZE(intercon));
On Mon, 9 Apr 2012, Jesper Juhl wrote:
While reading through sound/soc/codecs/wm8994.c I noticed a fair amount of trailing whitespace. This patch gets rid of it.
Signed-off-by: Jesper Juhl jj@chaosbits.net
Jesper,
is it really worth it? The code should have been fixed before merging, yes, but once it's there, such fixups tend to only make people angry (because they have to do unnecessary extra steps during git blame).
On Mon, Apr 9, 2012 at 00:02, Jiri Kosina jkosina@suse.cz wrote:
On Mon, 9 Apr 2012, Jesper Juhl wrote:
While reading through sound/soc/codecs/wm8994.c I noticed a fair amount of trailing whitespace. This patch gets rid of it.
Signed-off-by: Jesper Juhl jj@chaosbits.net
Jesper,
is it really worth it? The code should have been fixed before merging, yes, but once it's there, such fixups tend to only make people angry (because they have to do unnecessary extra steps during git blame).
If I may interject, I assume you mean that nobody wants to see the fact that somebody simply changed whitespace. However, the text of `git help blame' suggests that the `-w' flag obviates the issue:
Ignore whitespace when comparing the parent's version and the child’s to find where the lines came from.
Of course, I've never used it, so I may be mistaken in my interpretation.
Sincerely, Michael Witten
On Mon, 9 Apr 2012, Michael Witten wrote:
While reading through sound/soc/codecs/wm8994.c I noticed a fair amount of trailing whitespace. This patch gets rid of it.
Signed-off-by: Jesper Juhl jj@chaosbits.net
Jesper,
is it really worth it? The code should have been fixed before merging, yes, but once it's there, such fixups tend to only make people angry (because they have to do unnecessary extra steps during git blame).
If I may interject, I assume you mean that nobody wants to see the fact that somebody simply changed whitespace. However, the text of `git help blame' suggests that the `-w' flag obviates the issue:
Ignore whitespace when comparing the parent's version and the child’s to find where the lines came from.
Of course, I've never used it, so I may be mistaken in my interpretation.
That indeed does what it should do, but as it's not git default, then quitting git blame and reruning it with '-w' seems to be equally annoying to quitting git blame and reruning it with 'particular_commit~1"
On Mon, Apr 9, 2012 at 00:29, Jiri Kosina jkosina@suse.cz wrote:
On Mon, 9 Apr 2012, Michael Witten wrote:
While reading through sound/soc/codecs/wm8994.c I noticed a fair amount of trailing whitespace. This patch gets rid of it.
Signed-off-by: Jesper Juhl jj@chaosbits.net
Jesper,
is it really worth it? The code should have been fixed before merging, yes, but once it's there, such fixups tend to only make people angry (because they have to do unnecessary extra steps during git blame).
If I may interject, I assume you mean that nobody wants to see the fact that somebody simply changed whitespace. However, the text of `git help blame' suggests that the `-w' flag obviates the issue:
Ignore whitespace when comparing the parent's version and the child’s to find where the lines came from.
Of course, I've never used it, so I may be mistaken in my interpretation.
That indeed does what it should do, but as it's not git default, then quitting git blame and reruning it with '-w' seems to be equally annoying to quitting git blame and reruning it with 'particular_commit~1"
It seems to me that something must be terribly wrong with our tools and workflows whenever an improvement (for which the main work has already been done, no less) is turned down.
Perhaps that `-w' option should become the default.
On Mon, 9 Apr 2012, Jiri Kosina wrote:
On Mon, 9 Apr 2012, Jesper Juhl wrote:
While reading through sound/soc/codecs/wm8994.c I noticed a fair amount of trailing whitespace. This patch gets rid of it.
Signed-off-by: Jesper Juhl jj@chaosbits.net
Jesper,
is it really worth it?
Maybe not. I just noticed it while I was reading through the file for other purposes and it annoyed me.
The code should have been fixed before merging, yes, but once it's there, such fixups tend to only make people angry (because they have to do unnecessary extra steps during git blame).
I think it's nice to get little things like this cleaned up, but at the same time I don't want to annoy other people. I won't yell if you decide to just drop this patch.
participants (3)
-
Jesper Juhl -
Jiri Kosina -
Michael Witten