[alsa-devel] [PATCH 01/11] ALSA: pxa2xx-ac97: Remove redundant platform_set_drvdata()
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org Cc: Eric Miao eric.y.miao@gmail.com --- sound/arm/pxa2xx-ac97.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/arm/pxa2xx-ac97.c b/sound/arm/pxa2xx-ac97.c index ec54be4..ce431e6 100644 --- a/sound/arm/pxa2xx-ac97.c +++ b/sound/arm/pxa2xx-ac97.c @@ -230,7 +230,6 @@ static int pxa2xx_ac97_remove(struct platform_device *dev)
if (card) { snd_card_free(card); - platform_set_drvdata(dev, NULL); pxa2xx_ac97_hw_remove(dev); }
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org Cc: Jaroslav Kysela perex@perex.cz --- sound/drivers/aloop.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/drivers/aloop.c b/sound/drivers/aloop.c index 6f78de9..f758992 100644 --- a/sound/drivers/aloop.c +++ b/sound/drivers/aloop.c @@ -1183,7 +1183,6 @@ static int loopback_probe(struct platform_device *devptr) static int loopback_remove(struct platform_device *devptr) { snd_card_free(platform_get_drvdata(devptr)); - platform_set_drvdata(devptr, NULL); return 0; }
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org --- sound/drivers/ml403-ac97cr.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/drivers/ml403-ac97cr.c b/sound/drivers/ml403-ac97cr.c index 8125a7e..95ea4a1 100644 --- a/sound/drivers/ml403-ac97cr.c +++ b/sound/drivers/ml403-ac97cr.c @@ -1325,7 +1325,6 @@ static int snd_ml403_ac97cr_probe(struct platform_device *pfdev) static int snd_ml403_ac97cr_remove(struct platform_device *pfdev) { snd_card_free(platform_get_drvdata(pfdev)); - platform_set_drvdata(pfdev, NULL); return 0; }
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org --- sound/drivers/mpu401/mpu401.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/drivers/mpu401/mpu401.c b/sound/drivers/mpu401/mpu401.c index da1a29b..90a3a7b 100644 --- a/sound/drivers/mpu401/mpu401.c +++ b/sound/drivers/mpu401/mpu401.c @@ -129,7 +129,6 @@ static int snd_mpu401_probe(struct platform_device *devptr) static int snd_mpu401_remove(struct platform_device *devptr) { snd_card_free(platform_get_drvdata(devptr)); - platform_set_drvdata(devptr, NULL); return 0; }
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org --- sound/drivers/mtpav.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/drivers/mtpav.c b/sound/drivers/mtpav.c index 9f1815b..e5ec7eb 100644 --- a/sound/drivers/mtpav.c +++ b/sound/drivers/mtpav.c @@ -749,7 +749,6 @@ static int snd_mtpav_probe(struct platform_device *dev) static int snd_mtpav_remove(struct platform_device *devptr) { snd_card_free(platform_get_drvdata(devptr)); - platform_set_drvdata(devptr, NULL); return 0; }
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org Cc: Stas Sergeev stsp@users.sourceforge.net --- sound/drivers/pcsp/pcsp.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/drivers/pcsp/pcsp.c b/sound/drivers/pcsp/pcsp.c index 7a5fdb9..1c19cd7 100644 --- a/sound/drivers/pcsp/pcsp.c +++ b/sound/drivers/pcsp/pcsp.c @@ -189,7 +189,6 @@ static int pcsp_remove(struct platform_device *dev) struct snd_pcsp *chip = platform_get_drvdata(dev); alsa_card_pcsp_exit(chip); pcspkr_input_remove(chip->input_dev); - platform_set_drvdata(dev, NULL); return 0; }
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org --- sound/drivers/serial-u16550.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/drivers/serial-u16550.c b/sound/drivers/serial-u16550.c index 7425dd8..e0bf5e7 100644 --- a/sound/drivers/serial-u16550.c +++ b/sound/drivers/serial-u16550.c @@ -985,7 +985,6 @@ static int snd_serial_probe(struct platform_device *devptr) static int snd_serial_remove(struct platform_device *devptr) { snd_card_free(platform_get_drvdata(devptr)); - platform_set_drvdata(devptr, NULL); return 0; }
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org --- sound/drivers/virmidi.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/drivers/virmidi.c b/sound/drivers/virmidi.c index cc4be88..ace3879 100644 --- a/sound/drivers/virmidi.c +++ b/sound/drivers/virmidi.c @@ -132,7 +132,6 @@ static int snd_virmidi_probe(struct platform_device *devptr) static int snd_virmidi_remove(struct platform_device *devptr) { snd_card_free(platform_get_drvdata(devptr)); - platform_set_drvdata(devptr, NULL); return 0; }
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org --- sound/ppc/powermac.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/ppc/powermac.c b/sound/ppc/powermac.c index 09fc848..8abb521 100644 --- a/sound/ppc/powermac.c +++ b/sound/ppc/powermac.c @@ -139,7 +139,6 @@ __error: static int snd_pmac_remove(struct platform_device *devptr) { snd_card_free(platform_get_drvdata(devptr)); - platform_set_drvdata(devptr, NULL); return 0; }
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org Cc: Adrian McMenamin adrian@mcmen.demon.co.uk --- sound/sh/aica.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/sh/aica.c b/sound/sh/aica.c index e59a73a..78a3697 100644 --- a/sound/sh/aica.c +++ b/sound/sh/aica.c @@ -598,7 +598,6 @@ static int snd_aica_remove(struct platform_device *devptr) return -ENODEV; snd_card_free(dreamcastcard->card); kfree(dreamcastcard); - platform_set_drvdata(devptr, NULL); return 0; }
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org Cc: Rafael Ignacio Zurita rizurita@yahoo.com --- sound/sh/sh_dac_audio.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/sound/sh/sh_dac_audio.c b/sound/sh/sh_dac_audio.c index e68c4fc..7c9422c 100644 --- a/sound/sh/sh_dac_audio.c +++ b/sound/sh/sh_dac_audio.c @@ -290,8 +290,6 @@ static int snd_sh_dac_pcm(struct snd_sh_dac *chip, int device) static int snd_sh_dac_remove(struct platform_device *devptr) { snd_card_free(platform_get_drvdata(devptr)); - platform_set_drvdata(devptr, NULL); - return 0; }
On Mon, May 20, 2013 at 02:08:34PM +0530, Sachin Kamat wrote:
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Always CC maintainers on patches...
At Mon, 20 May 2013 14:08:34 +0530, Sachin Kamat wrote:
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org Cc: Eric Miao eric.y.miao@gmail.com
Thanks, applied all 11 patches.
Takashi
sound/arm/pxa2xx-ac97.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/arm/pxa2xx-ac97.c b/sound/arm/pxa2xx-ac97.c index ec54be4..ce431e6 100644 --- a/sound/arm/pxa2xx-ac97.c +++ b/sound/arm/pxa2xx-ac97.c @@ -230,7 +230,6 @@ static int pxa2xx_ac97_remove(struct platform_device *dev)
if (card) { snd_card_free(card);
platform_set_drvdata(dev, NULL);-- 1.7.9.5
participants (3)
-
Mark Brown -
Sachin Kamat -
Takashi Iwai