[alsa-devel] [PATCH] sound: codecs: fix a missing check for regmap_update_bits
25 Mar
2019
25 Mar
'19
12:25 a.m.
regmap_update_bits could fail. The fix checks its status and if it fails, returns its error code upstream.
Signed-off-by: Kangjie Lu kjlu@umn.edu --- sound/soc/codecs/cs35l34.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/cs35l34.c b/sound/soc/codecs/cs35l34.c index 5063c05afa27..a456b1ac9019 100644 --- a/sound/soc/codecs/cs35l34.c +++ b/sound/soc/codecs/cs35l34.c @@ -262,6 +262,8 @@ static int cs35l34_sdin_event(struct snd_soc_dapm_widget *w, } ret = regmap_update_bits(priv->regmap, CS35L34_PWRCTL1, CS35L34_PDN_ALL, CS35L34_PDN_ALL); + if (ret < 0) + return ret; break; default: pr_err("Invalid event = 0x%x\n", event);
--
2.17.1
2101
Age (days ago)
2101
Last active (days ago)
0 comments
1 participants
participants (1)
-
Kangjie Lu