[PATCH] ALSA: hda/realtek: Remove Framework Laptop 16 from quirks
The Framework Laptop 16 does not have a combination headphone/headset 3.5mm jack; however, applying the pincfg from the Laptop 13 (nid=0x19) erroneously informs hda that the node is present.
Fixes: 8804fa04a492 ("ALSA: hda/realtek: Add Framework laptop 16 to quirks") Signed-off-by: Dustin L. Howett dustin@howett.net --- sound/pci/hda/patch_realtek.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index e3c0b9d5552d..127f5933abd7 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -10605,7 +10605,6 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", ALC256_FIXUP_INTEL_NUC10), SND_PCI_QUIRK(0x8086, 0x3038, "Intel NUC 13", ALC295_FIXUP_CHROME_BOOK), SND_PCI_QUIRK(0xf111, 0x0001, "Framework Laptop", ALC295_FIXUP_FRAMEWORK_LAPTOP_MIC_NO_PRESENCE), - SND_PCI_QUIRK(0xf111, 0x0005, "Framework Laptop", ALC295_FIXUP_FRAMEWORK_LAPTOP_MIC_NO_PRESENCE), SND_PCI_QUIRK(0xf111, 0x0006, "Framework Laptop", ALC295_FIXUP_FRAMEWORK_LAPTOP_MIC_NO_PRESENCE),
#if 0
--- base-commit: 7b44d5381e541de3da3cee2e948456b250f41f25 change-id: 20240605-alsa-hda-realtek-remove-framework-laptop-16-from-quirks-dc60267cb5e7
Best regards,
On 6/5/2024 12:01, Dustin L. Howett wrote:
The Framework Laptop 16 does not have a combination headphone/headset 3.5mm jack; however, applying the pincfg from the Laptop 13 (nid=0x19) erroneously informs hda that the node is present.
But doesn't the audio card work this way?
Fixes: 8804fa04a492 ("ALSA: hda/realtek: Add Framework laptop 16 to quirks") Signed-off-by: Dustin L. Howett dustin@howett.net
sound/pci/hda/patch_realtek.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index e3c0b9d5552d..127f5933abd7 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -10605,7 +10605,6 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", ALC256_FIXUP_INTEL_NUC10), SND_PCI_QUIRK(0x8086, 0x3038, "Intel NUC 13", ALC295_FIXUP_CHROME_BOOK), SND_PCI_QUIRK(0xf111, 0x0001, "Framework Laptop", ALC295_FIXUP_FRAMEWORK_LAPTOP_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0xf111, 0x0005, "Framework Laptop", ALC295_FIXUP_FRAMEWORK_LAPTOP_MIC_NO_PRESENCE), SND_PCI_QUIRK(0xf111, 0x0006, "Framework Laptop", ALC295_FIXUP_FRAMEWORK_LAPTOP_MIC_NO_PRESENCE),
#if 0
base-commit: 7b44d5381e541de3da3cee2e948456b250f41f25 change-id: 20240605-alsa-hda-realtek-remove-framework-laptop-16-from-quirks-dc60267cb5e7
Best regards,
On Wed, Jun 5, 2024 at 12:03 PM Mario Limonciello mario.limonciello@amd.com wrote:
On 6/5/2024 12:01, Dustin L. Howett wrote:
The Framework Laptop 16 does not have a combination headphone/headset 3.5mm jack; however, applying the pincfg from the Laptop 13 (nid=0x19) erroneously informs hda that the node is present.
But doesn't the audio card work this way?
I don't believe so - the audio expansion card enumerates as a USB device that is picked up by snd-usb-audio. A headset microphone connected to the audio expansion card seems to continue working properly even with this pinctrl change (synthetically tested on my Framework Laptop 13, mind you -- it is not a perfect test :)).
d
The audio expansion card has a full usb to headphone jack codec. So does not interact with HDA at all.
On Thu, Jun 6, 2024, 1:11 AM Dustin Howett dustin@howett.net wrote:
On Wed, Jun 5, 2024 at 12:03 PM Mario Limonciello mario.limonciello@amd.com wrote:
On 6/5/2024 12:01, Dustin L. Howett wrote:
The Framework Laptop 16 does not have a combination headphone/headset 3.5mm jack; however, applying the pincfg from the Laptop 13 (nid=0x19) erroneously informs hda that the node is present.
But doesn't the audio card work this way?
I don't believe so - the audio expansion card enumerates as a USB device that is picked up by snd-usb-audio. A headset microphone connected to the audio expansion card seems to continue working properly even with this pinctrl change (synthetically tested on my Framework Laptop 13, mind you -- it is not a perfect test :)).
d
Thanks Dustin and Kieran. This approach makes sense to me then.
Reviewed-by: Mario Limonciello mario.limonciello@amd.com
On 6/5/2024 6:15 PM, Kieran Levin wrote:
The audio expansion card has a full usb to headphone jack codec. So does not interact with HDA at all.
On Thu, Jun 6, 2024, 1:11 AM Dustin Howett <dustin@howett.net mailto:dustin@howett.net> wrote:
On Wed, Jun 5, 2024 at 12:03 PM Mario Limonciello <mario.limonciello@amd.com <mailto:mario.limonciello@amd.com>> wrote: > > On 6/5/2024 12:01, Dustin L. Howett wrote: > > The Framework Laptop 16 does not have a combination headphone/headset > > 3.5mm jack; however, applying the pincfg from the Laptop 13 (nid=0x19) > > erroneously informs hda that the node is present. > > But doesn't the audio card work this way? I don't believe so - the audio expansion card enumerates as a USB device that is picked up by snd-usb-audio. A headset microphone connected to the audio expansion card seems to continue working properly even with this pinctrl change (synthetically tested on my Framework Laptop 13, mind you -- it is not a perfect test :)). d
On Wed, 05 Jun 2024 19:01:32 +0200, Dustin L. Howett wrote:
The Framework Laptop 16 does not have a combination headphone/headset 3.5mm jack; however, applying the pincfg from the Laptop 13 (nid=0x19) erroneously informs hda that the node is present.
Fixes: 8804fa04a492 ("ALSA: hda/realtek: Add Framework laptop 16 to quirks") Signed-off-by: Dustin L. Howett dustin@howett.net
Applied now. Thanks.
Takashi
participants (5)
-
Dustin Howett -
Dustin L. Howett
-
Kieran Levin -
Limonciello, Mario -
Mario Limonciello
-
Takashi Iwai