At Wed, 27 Aug 2008 11:37:44 +0200, Tejun Heo wrote:

Hello,

Takashi Iwai wrote:

...

...

+config SOUND_OSS_CORE

• bool
• default n

source "sound/oss/dmasound/Kconfig"

This seems missing from the scope. But, I think this should be rather in the block "if SOUND_PRIME" below.

SOUND_OSS_CORE should be turned on if ALSA OSS emul is turned on or arch-um hostsound is turned on, both of which can be enabled regardless of SOUND_PRIME, no?

Yes, sorry, I didn't cite clearly. I meant only the last line. sound/oss/dmasound/Kconfig is included and evaluated outside the block "if SOUND_PRIME". Thus, CONFIG_SOUND_OSS_CORE won't be enabled for drivers in sound/oss/dmasound.

My suggestion is to move that line source sound/oss/dmasound/Kconfig into the "if SOUND_PRIME" block first, then apply your patch.

Anyway, there are some other minor issues in sound/Kconfig, for example, why "if !M68K" is there. We can clean up a bit more.

thanks,

Takashi