[alsa-devel] [PATCH] ASoC: qcom: Remove QCOM dependency from LPASS variants
From: Kenneth Westfield kwestfie@codeaurora.org
Remove the dependency on SND_SOC_QCOM from the user- invisible LPASS variant options. This will fix randconfig build errors.
Reported-by: Jim Davis jim.epost@gmail.com Fixes: dc1ebd1811e9 ("ASoC: qcom: Add apq8016 lpass driver support") Fixes: 9bae4880acee ("ASoC: qcom: move ipq806x specific bits out of lpass driver") Signed-off-by: Kenneth Westfield kwestfie@codeaurora.org ---
Created fix in response to Jim's bug report: http://mailman.alsa-project.org/pipermail/alsa-devel/2015-May/092870.html
Note: I did some searching but didn't see an example of a fix for the same type of bug introduced by 2 commits. If this needs to be split into two fixes, let me know.
sound/soc/qcom/Kconfig | 2 -- 1 file changed, 2 deletions(-)
diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig index 29fff6d..10837bd 100644 --- a/sound/soc/qcom/Kconfig +++ b/sound/soc/qcom/Kconfig @@ -14,13 +14,11 @@ config SND_SOC_LPASS_PLATFORM
config SND_SOC_LPASS_IPQ806X tristate - depends on SND_SOC_QCOM select SND_SOC_LPASS_CPU select SND_SOC_LPASS_PLATFORM
config SND_SOC_LPASS_APQ8016 tristate - depends on SND_SOC_QCOM select SND_SOC_LPASS_CPU select SND_SOC_LPASS_PLATFORM
On Mon, Jun 01, 2015 at 10:05:32PM -0700, Kenneth Westfield wrote:
Remove the dependency on SND_SOC_QCOM from the user- invisible LPASS variant options. This will fix randconfig build errors.
I can't tell from this commit message what the patch is supposed to do - what are the bugs and in what way will this fix them?
The patch
ASoC: qcom: remove Kconfig deps from variant configs
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 7f005256f70a8c1c60b2f8a7449137da0c5e5bd9 Mon Sep 17 00:00:00 2001
From: Kenneth Westfield kwestfie@codeaurora.org Date: Thu, 18 Jun 2015 15:16:08 -0700 Subject: [PATCH] ASoC: qcom: remove Kconfig deps from variant configs
Remove the SND_SOC_QCOM dependency from the variant configs. The board configs, which select the variants, already have this dependency.
Signed-off-by: Kenneth Westfield kwestfie@codeaurora.org Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/qcom/Kconfig | 2 -- 1 file changed, 2 deletions(-)
diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig index d6ccda7..3cc252e 100644 --- a/sound/soc/qcom/Kconfig +++ b/sound/soc/qcom/Kconfig @@ -15,13 +15,11 @@ config SND_SOC_LPASS_PLATFORM
config SND_SOC_LPASS_IPQ806X tristate - depends on SND_SOC_QCOM select SND_SOC_LPASS_CPU select SND_SOC_LPASS_PLATFORM
config SND_SOC_LPASS_APQ8016 tristate - depends on SND_SOC_QCOM select SND_SOC_LPASS_CPU select SND_SOC_LPASS_PLATFORM
participants (2)
-
Kenneth Westfield -
Mark Brown