[alsa-devel] [PATCH] ASoC: core: Split the union for CODEC/platform in the DAI
There's now core code which falls back to global CODEC operations for DAI calls that needs to be able to tell if it's dealing with a CPU or CODEC DAI and given the small number of DAIs in a typical system and overall memory usage pattern saving a pointer per DAI is really not worth the effort.
Reported-by: Ian Lartey ian@opensource.wolfsonmicro.com Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com --- include/sound/soc-dai.h | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h index d474128..868f4b6 100644 --- a/include/sound/soc-dai.h +++ b/include/sound/soc-dai.h @@ -250,10 +250,9 @@ struct snd_soc_dai { unsigned int rate;
/* parent platform/codec */ - union { - struct snd_soc_platform *platform; - struct snd_soc_codec *codec; - }; + struct snd_soc_platform *platform; + struct snd_soc_codec *codec; + struct snd_soc_card *card;
struct list_head list;
On Fri, 2012-03-02 at 16:19 +0000, Mark Brown wrote:
There's now core code which falls back to global CODEC operations for DAI calls that needs to be able to tell if it's dealing with a CPU or CODEC DAI and given the small number of DAIs in a typical system and overall memory usage pattern saving a pointer per DAI is really not worth the effort.
Reported-by: Ian Lartey ian@opensource.wolfsonmicro.com Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com
Acked-by: Liam Girdwood lrg@ti.com
participants (2)
-
Liam Girdwood
-
Mark Brown