[alsa-devel] [PATCH] Recognise and use subdevice 0x3061 found in some HP dv6 notebooks.
Obvious patch. Recently bought an HP Pavilion dv6-1110ax notebook. The modparm 'model=hp-dv5' works, but I thought it was better if it were natively supported.
Also, the 'hp_detect=1' hint (echo "hp_detect = 1" > /sys/class/sound/hwC0D0/hints) works nicely to mute the speakers when using the headphone jack(s). Is there any way to automatically enable this? I'm no alsa dev - just scratching my itch here ;)
PS: I'm not subscribed to the list - so, please put me in Cc: in the replies.
Thanks, Kunal
Signed-off-by: Kunal Gangakhedkar kunal.gangakhedkar@gmail.com --- sound/pci/hda/patch_sigmatel.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index 3d59f83..0ed9a09 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -1725,6 +1725,8 @@ static struct snd_pci_quirk stac92hd71bxx_cfg_tbl[] = { "HP HDX", STAC_HP_HDX), /* HDX16 */ SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xfff0, 0x3620, "HP dv6", STAC_HP_DV5), + SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xfff0, 0x3061, + "HP dv6", STAC_HP_DV5), /* HP Pavilion dv6-1110ax */ SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xfff0, 0x7010, "HP", STAC_HP_DV5), SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0233,
At Mon, 14 Dec 2009 00:29:42 +0530, Kunal Gangakhedkar wrote:
Obvious patch. Recently bought an HP Pavilion dv6-1110ax notebook. The modparm 'model=hp-dv5' works, but I thought it was better if it were natively supported.
Also, the 'hp_detect=1' hint (echo "hp_detect = 1" > /sys/class/sound/hwC0D0/hints) works nicely to mute the speakers when using the headphone jack(s). Is there any way to automatically enable this?
This is weird. hp_detect is basically always set unless you clear explicitly. I guess it's simply a known IRQ problem on HP dv laptops. It requires MSI.
Anyway, could you test the very latest kernel without your patch and confirm that the change is still needed?
thanks,
Takashi
On Monday 14 Dec 2009 3:37:14 pm Takashi Iwai wrote:
At Mon, 14 Dec 2009 00:29:42 +0530, Kunal Gangakhedkar wrote:
Obvious patch. Recently bought an HP Pavilion dv6-1110ax notebook. The modparm 'model=hp-dv5' works, but I thought it was better if it were natively supported.
Also, the 'hp_detect=1' hint (echo "hp_detect = 1" > /sys/class/sound/hwC0D0/hints) works nicely to mute the speakers when using the headphone jack(s). Is there any way to automatically enable this?
This is weird. hp_detect is basically always set unless you clear explicitly. I guess it's simply a known IRQ problem on HP dv laptops. It requires MSI.
Anyway, could you test the very latest kernel without your patch and confirm that the change is still needed?
The patch wasn't about hp_detect. It was to get the subdev recognised natively so that you don't need the 'model=hp-dv5' modparm.
I'll try with enable_msi modparm as well without trying the hp_detect hint and let you know about it. Will also try the latest kernel.
Thanks, Kunal
At Mon, 14 Dec 2009 15:53:54 +0530, Kunal Gangakhedkar wrote:
On Monday 14 Dec 2009 3:37:14 pm Takashi Iwai wrote:
At Mon, 14 Dec 2009 00:29:42 +0530, Kunal Gangakhedkar wrote:
Obvious patch. Recently bought an HP Pavilion dv6-1110ax notebook. The modparm 'model=hp-dv5' works, but I thought it was better if it were natively supported.
Also, the 'hp_detect=1' hint (echo "hp_detect = 1" > /sys/class/sound/hwC0D0/hints) works nicely to mute the speakers when using the headphone jack(s). Is there any way to automatically enable this?
This is weird. hp_detect is basically always set unless you clear explicitly. I guess it's simply a known IRQ problem on HP dv laptops. It requires MSI.
Anyway, could you test the very latest kernel without your patch and confirm that the change is still needed?
The patch wasn't about hp_detect. It was to get the subdev recognised natively so that you don't need the 'model=hp-dv5' modparm.
Yeah, I know. But the speaker-muting should work even without hp_detect=1 hints. The IRQ thingy was only about the auto-muting.
Also, with the latest version, the device might work even without the extra model option (as the auto-parser got improved). I'd like to avoid unneeded quirk lines as much as possible, so that's why I asked to check the latest one.
I'll try with enable_msi modparm as well without trying the hp_detect hint and let you know about it. Will also try the latest kernel.
Thanks!
Takashi
participants (2)
-
Kunal Gangakhedkar -
Takashi Iwai