Re: [PATCH v2] Fixes: 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers")
On 2022-07-06 6:21 PM, Ryan.Wanner@microchip.com wrote:
From: Ryan Wanner Ryan.Wanner@microchip.com
Fixed typo in i2s1 node
Perhaps this email got twisted by my client but what I'm seeing is fixes-tag instead of a proper commit title.
If that's really the case, please reword your title - Fixes-tag belongs to the tag area and should be placed before your final signed-off tag.
Also, as commit message is _not_ a title and is made of sentences, it is expected to have each end with '.'. Another suggestion - nothing is "Fixed" when patch lands on the mailing list. It's just a proposal until it actually gets integrated by the maintainer. As change targets _current_ code, s/Fixed/Fix/ is the recommended phrasing.
Czarek
Signed-off-by: Ryan Wanner Ryan.Wanner@microchip.com
participants (1)
-
Cezary Rojewski