-----Original Message----- From: Lothar Waßmann [mailto:LW@KARO-electronics.de] Sent: Friday, November 18, 2011 4:30 PM To: Dong Aisheng-B29396 Cc: Marek Vasut; alsa-devel@alsa-project.org; s.hauer@pengutronix.de; broonie@opensource.wolfsonmicro.com; w.sang@pengutronix.de; Guo Shawn- R65073; kernel@pengutronix.de; u.kleine-koenig@pengutronix.de; lrg@ti.com; linux-arm-kernel@lists.infradead.org Subject: RE: [alsa-devel] [PATCH v5 1/3] ARM: mxs: add saif clkmux functions

Hi,

Dong Aisheng-B29396 writes: [...]

...

...

...

+#define HW_DIGCTL_CTRL 0x0 +#define BP_DIGCTL_CTRL_SAIF_CLKMUX (10)

Do you need the parenthesis above ?

I'm not sure about his. HW_DIGCTL_CTRL is the register offset. Do we have to do this?

You need parens around macro parameters that are used in an expression inside the macro. But you never ever need to enclose a bare number in parens!

Yep! I will remove it. Saving two bytes in code size! :-) Regards Dong Aisheng