[alsa-devel] [PATCH 1/2] ASoC: rt5645: Fix a serious typo
The patch corrects a serious typo in struct reg_default.
Signed-off-by: Oder Chiou oder_chiou@realtek.com --- sound/soc/codecs/rt5645.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 6db6f81..30410eb 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -50,10 +50,10 @@ static const struct regmap_range_cfg rt5645_ranges[] = {
static const struct reg_default init_list[] = { {RT5645_PR_BASE + 0x3d, 0x3600}, - {RT5645_PR_BASE + 0x1c, 0xfd20); - {RT5645_PR_BASE + 0x20, 0x611f); - {RT5645_PR_BASE + 0x21, 0x4040); - {RT5645_PR_BASE + 0x23, 0x0004); + {RT5645_PR_BASE + 0x1c, 0xfd20}, + {RT5645_PR_BASE + 0x20, 0x611f}, + {RT5645_PR_BASE + 0x21, 0x4040}, + {RT5645_PR_BASE + 0x23, 0x0004}, }; #define RT5645_INIT_REG_LEN ARRAY_SIZE(init_list)
Return statements in functions returning bool should use true/false instead of 1/0.
Signed-off-by: Oder Chiou oder_chiou@realtek.com --- sound/soc/codecs/rt5645.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 30410eb..68923ec 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -242,9 +242,9 @@ static bool rt5645_volatile_register(struct device *dev, unsigned int reg) case RT5645_VENDOR_ID: case RT5645_VENDOR_ID1: case RT5645_VENDOR_ID2: - return 1; + return true; default: - return 0; + return false; } }
@@ -391,9 +391,9 @@ static bool rt5645_readable_register(struct device *dev, unsigned int reg) case RT5645_VENDOR_ID: case RT5645_VENDOR_ID1: case RT5645_VENDOR_ID2: - return 1; + return true; default: - return 0; + return false; } }
participants (2)
-
Mark Brown -
Oder Chiou