Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec
On Fri, Apr 22, 2016 at 09:37:39AM -0700, Jeremy McDermond wrote:
components fairly well. I’m just trying to wrap my head around where this all would fit in. Should the codec driver just register a bunch of clock components in its initialization somewhere? I’m thinking that it can’t have its own CCF driver separate from the codec driver because you won’t have proper access to the registers over I2C or SPI. I don’t find a lot of examples in the codec drivers, and there aren’t very many other drivers in the tree that seem to register clocks with CCF that I can find.
If the clock code is worth splitting off into a separate driver that's what drivers/mfd is for.
On Apr 25, 2016, at 5:55 AM, Mark Brown broonie@kernel.org wrote:
If the clock code is worth splitting off into a separate driver that's what drivers/mfd is for.
I have my doubts that it’s worth splitting off into a separate driver. There’s not a lot of use for it outside of the internals of the tlv320aic3204. There is a provision for putting the PLL output on a GPIO pin of the chip, but I’m not sure that’s a justification for breaking out the clock stuff into its own driver. Nobody’s going to put a tlv320aic3204 chip on their boards because of the clocking; they’re going to put it there to be a codec.
-- Jeremy McDermond (NH6Z) Xenotropic Systems mcdermj@xenotropic.com
participants (2)
-
Jeremy McDermond -
Mark Brown