Re: [alsa-devel] [PATCH] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node
Hi Inki,
Cc: alsa-devel@alsa-project.org
On 03/08/2018 09:15 AM, Inki Dae wrote:
By the way, it seems 'sound-dai-cells' property never affect Exynos4210/4212> 5420/5433. It seems that even through ALSA TM2 audio driver(tm2_wm5110.c) exists the driver never check the property.
However, this patch adds below description.
"Optional properties for Exynos 4210, 4212, 5420 and 5433"
Is there a possibility for other boards based on Exynos4210/4212/5420/5433 SoC to use this property later?
All these SoCs have the HDMI IP block which has one input DAI, connected internally over I2S bus with the IS2 controller.
I think there is no advantage in limiting ourselves now only to SoC's for which we currently rely on that DT property in current kernel code, just to update this documentation later when we actually put the property in dts files.
In case of exynos5420 we already require #sound-dai-cells for Odroid and I have also a patch for exynos5420-peach-pit board which will need it as well.
As far as exynos4210 and exynos4212 are concerned it's a matter of adding support for Odroid-U3, then we will also need this property because we are going to use "multi-codec" (HDMI and external I2S0 pins for CODEC are wired in parallel).
In case of exynos5433 it just happens that the code in current driver doesn't require #sound-dai-cells property - one of the reasons I made it this way was to avoid dependency on dts, but it doesn't imply we should describe the HW in DT incompletely. Once the property is in dtbs we can update the driver to use more generic code, instead of open coding things.
Actually I have forgotten to add also exynos5250 to the list.
Hi Sylwester,
2018년 03월 08일 20:22에 Sylwester Nawrocki 이(가) 쓴 글:
Hi Inki,
Cc: alsa-devel@alsa-project.org
On 03/08/2018 09:15 AM, Inki Dae wrote:
By the way, it seems 'sound-dai-cells' property never affect Exynos4210/4212> 5420/5433. It seems that even through ALSA TM2 audio driver(tm2_wm5110.c) exists the driver never check the property.
However, this patch adds below description.
"Optional properties for Exynos 4210, 4212, 5420 and 5433"
Is there a possibility for other boards based on Exynos4210/4212/5420/5433 SoC to use this property later?
All these SoCs have the HDMI IP block which has one input DAI, connected internally over I2S bus with the IS2 controller.
I think there is no advantage in limiting ourselves now only to SoC's for which we currently rely on that DT property in current kernel code, just to update this documentation later when we actually put the property in dts files.
In case of exynos5420 we already require #sound-dai-cells for Odroid and
Maybe exynos5422? Odroid XU3/4 use Exynos5422.
I have also a patch for exynos5420-peach-pit board which will need it as well.
As far as exynos4210 and exynos4212 are concerned it's a matter of adding support for Odroid-U3, then we will also need this property because we are going to use "multi-codec" (HDMI and external I2S0 pins for CODEC are wired in parallel).
In case of exynos5433 it just happens that the code in current driver doesn't require #sound-dai-cells property - one of the reasons I made it this way was to avoid dependency on dts, but it doesn't imply we should describe the HW in DT incompletely. Once the property is in dtbs we can update the driver to use more generic code, instead of open coding things.
Good idea.
Actually I have forgotten to add also exynos5250 to the list.
Seems that '#sound-dai-cells' is required mandatorily in case of Exynos5422 because Odroid XU3/4 Audio driver checks this property, and the driver returns error if the property doesn't exist in its device tree. And if other SoCs - Exynos4210/4212/5250/5420/5433 - require this property with additional driver works later then this property would also be required mandatorily for them not optionally. In this case we may need to modify the description again.
So my opinion is to add only the description required mandatorily if I understood correctly.
Thanks, Inki Dae
On 03/09/2018 03:35 AM, Inki Dae wrote:
2018년 03월 08일 20:22에 Sylwester Nawrocki 이(가) 쓴 글:
On 03/08/2018 09:15 AM, Inki Dae wrote:
[...]
Is there a possibility for other boards based on Exynos4210/4212/5420/5433 SoC to use this property later?
All these SoCs have the HDMI IP block which has one input DAI, connected internally over I2S bus with the I2S controller.
I think there is no advantage in limiting ourselves now only to SoC's for which we currently rely on that DT property in current kernel code, just to update this documentation later when we actually put the property in dts files.
In case of exynos5420 we already require #sound-dai-cells for Odroid and
Maybe exynos5422? Odroid XU3/4 use Exynos5422.
Yes, my mistake, Exynos5422 for Odroid and Exynos5420 for Peach-Pit. It just happens we use "samsung,exynos5420-hdmi" compatible for that both SoCs.
Seems that '#sound-dai-cells' is required mandatorily in case of Exynos5422 because Odroid XU3/4 Audio driver checks this property, and the driver returns error if the property doesn't exist in its device tree. And if other SoCs - Exynos4210/4212/5250/5420/5433 - require this property with additional driver works later then this property would also be required mandatorily for them not optionally. In this case we may need to modify the description again.
So my opinion is to add only the description required mandatorily if I understood correctly.
You are right, it would be better to make this a mandatory property, I only made it optional because now this property is missing in many dts files. Let me resend with #sound-dai-cells description moved to the "Required properties" paragraph.
-- Thanks, Sylwester
participants (2)
-
Inki Dae -
Sylwester Nawrocki