[alsa-devel] [PATCH 1/2] ASoC: omap: sdma-pcm: add module license
Kbuild warns that we should have a MODULE_LICENSE() tag in the new module:
WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o
This adds both the license and author field corresponding to the information at the top of the file.
Fixes: dde637f2daf1 ("ASoC: omap: Introduce the generic_dmaengine_pcm based sdma-pcm") Signed-off-by: Arnd Bergmann arnd@arndb.de --- sound/soc/omap/sdma-pcm.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/sound/soc/omap/sdma-pcm.c b/sound/soc/omap/sdma-pcm.c index f7b2b5b69d27..e9981bff8bd2 100644 --- a/sound/soc/omap/sdma-pcm.c +++ b/sound/soc/omap/sdma-pcm.c @@ -4,6 +4,7 @@ * Author: Peter Ujfalusi peter.ujfalusi@ti.com */
+#include <linux/module.h> #include <sound/core.h> #include <sound/pcm.h> #include <sound/pcm_params.h> @@ -66,3 +67,6 @@ int sdma_pcm_platform_register(struct device *dev, return devm_snd_dmaengine_pcm_register(dev, config, flags); } EXPORT_SYMBOL_GPL(sdma_pcm_platform_register); + +MODULE_AUTHOR("Peter Ujfalusi peter.ujfalusi@ti.com"); +MODULE_LICENSE("GPL v2");
The newly introduced driver causes a harmless Kconfig warning when compile-testing random configurations:
WARNING: unmet direct dependencies detected for SND_SDMA_SOC Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && DMA_OMAP [=n] Selected by [y]: - SND_OMAP_SOC [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && (ARCH_OMAP [=y] && DMA_OMAP [=n] || ARM [=y] && COMPILE_TEST [=y])
By simply allow build testing without DMA_OMAP, we can shut up that warning.
Fixes: dde637f2daf1 ("ASoC: omap: Introduce the generic_dmaengine_pcm based sdma-pcm") Signed-off-by: Arnd Bergmann arnd@arndb.de --- sound/soc/omap/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index f1d6799e08a9..6dccea6fdaeb 100644 --- a/sound/soc/omap/Kconfig +++ b/sound/soc/omap/Kconfig @@ -5,7 +5,7 @@ config SND_OMAP_SOC
config SND_SDMA_SOC tristate "SoC Audio for Texas Instruments chips using sDMA" - depends on DMA_OMAP + depends on DMA_OMAP || COMPILE_TEST select SND_SOC_GENERIC_DMAENGINE_PCM
config SND_OMAP_SOC_DMIC
The patch
ASoC: omap: fix compile-test building
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 500413c5097d981b1b6e639bf2183abc1db6c24a Mon Sep 17 00:00:00 2001
From: Arnd Bergmann arnd@arndb.de Date: Fri, 25 May 2018 18:02:32 +0200 Subject: [PATCH] ASoC: omap: fix compile-test building
The newly introduced driver causes a harmless Kconfig warning when compile-testing random configurations:
WARNING: unmet direct dependencies detected for SND_SDMA_SOC Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && DMA_OMAP [=n] Selected by [y]: - SND_OMAP_SOC [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && (ARCH_OMAP [=y] && DMA_OMAP [=n] || ARM [=y] && COMPILE_TEST [=y])
By simply allow build testing without DMA_OMAP, we can shut up that warning.
Fixes: dde637f2daf1 ("ASoC: omap: Introduce the generic_dmaengine_pcm based sdma-pcm") Signed-off-by: Arnd Bergmann arnd@arndb.de Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/omap/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index f1d6799e08a9..6dccea6fdaeb 100644 --- a/sound/soc/omap/Kconfig +++ b/sound/soc/omap/Kconfig @@ -5,7 +5,7 @@ config SND_OMAP_SOC
config SND_SDMA_SOC tristate "SoC Audio for Texas Instruments chips using sDMA" - depends on DMA_OMAP + depends on DMA_OMAP || COMPILE_TEST select SND_SOC_GENERIC_DMAENGINE_PCM
config SND_OMAP_SOC_DMIC
On Fri, May 25, 2018 at 06:02:31PM +0200, Arnd Bergmann wrote:
Kbuild warns that we should have a MODULE_LICENSE() tag in the new module:
WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o
This doesn't apply against current code, please check and resend.
On 2018-05-25 20:35, Mark Brown wrote:
On Fri, May 25, 2018 at 06:02:31PM +0200, Arnd Bergmann wrote:
Kbuild warns that we should have a MODULE_LICENSE() tag in the new module:
WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o
This doesn't apply against current code, please check and resend.
'ASoC: omap: sdma-pcm: Fix modpost warning' is already applied which adds the missing MODULE_LICENSE()
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
participants (3)
-
Arnd Bergmann -
Mark Brown -
Peter Ujfalusi