[alsa-devel] [PATCH] ALSA: seq_oss: Change structure initialisation to C99 style
Replace the in order struct initialisation style with explicit field style.
The Coccinelle semantic patch used to make this change is as follows:
@decl@ identifier i1,fld; type T; field list[n] fs; @@
struct i1 { fs T fld; ...};
@@ identifier decl.i1,i2,decl.fld; expression e; position bad.p, bad.fix; @@
struct i1 i2@p = { ..., + .fld = e - e@fix ,...};
Also, removed some unnecessary comments.
Signed-off-by: Amitoj Kaur Chawla amitoj1606@gmail.com --- sound/core/seq/oss/seq_oss_synth.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/core/seq/oss/seq_oss_synth.c b/sound/core/seq/oss/seq_oss_synth.c index b16dbef..cd0e0eb 100644 --- a/sound/core/seq/oss/seq_oss_synth.c +++ b/sound/core/seq/oss/seq_oss_synth.c @@ -70,11 +70,11 @@ struct seq_oss_synth { static int max_synth_devs; static struct seq_oss_synth *synth_devs[SNDRV_SEQ_OSS_MAX_SYNTH_DEVS]; static struct seq_oss_synth midi_synth_dev = { - -1, /* seq_device */ - SYNTH_TYPE_MIDI, /* synth_type */ - 0, /* synth_subtype */ - 16, /* nr_voices */ - "MIDI", /* name */ + .seq_device = -1, + .synth_type = SYNTH_TYPE_MIDI, + .synth_subtype = 0, + .nr_voices = 16, + .name = "MIDI", };
static DEFINE_SPINLOCK(register_lock);
On Wed, 15 Jun 2016 10:03:31 +0200, Amitoj Kaur Chawla wrote:
Replace the in order struct initialisation style with explicit field style.
The Coccinelle semantic patch used to make this change is as follows:
@decl@ identifier i1,fld; type T; field list[n] fs; @@
struct i1 { fs T fld; ...};
@@ identifier decl.i1,i2,decl.fld; expression e; position bad.p, bad.fix; @@
struct i1 i2@p = { ...,
- .fld = e
- e@fix
,...};
Also, removed some unnecessary comments.
Signed-off-by: Amitoj Kaur Chawla amitoj1606@gmail.com
Applied, thanks.
Takashi
participants (2)
-
Amitoj Kaur Chawla
-
Takashi Iwai