[alsa-devel] [PATCH] ASoC: sun4i-i2s: incorrect regmap for A83t
From: Marcus Cooper codekipper@gmail.com
Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T") Signed-off-by: Marcus Cooper codekipper@gmail.com --- sound/soc/sunxi/sun4i-i2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c index cbc6e59aa089..056a299c03fb 100644 --- a/sound/soc/sunxi/sun4i-i2s.c +++ b/sound/soc/sunxi/sun4i-i2s.c @@ -1109,7 +1109,7 @@ static const struct sun4i_i2s_quirks sun6i_a31_i2s_quirks = { static const struct sun4i_i2s_quirks sun8i_a83t_i2s_quirks = { .has_reset = true, .reg_offset_txdata = SUN8I_I2S_FIFO_TX_REG, - .sun4i_i2s_regmap = &sun4i_i2s_regmap_config, + .sun4i_i2s_regmap = &sun8i_i2s_regmap_config, .field_clkdiv_mclk_en = REG_FIELD(SUN4I_I2S_CLK_DIV_REG, 8, 8), .field_fmt_wss = REG_FIELD(SUN4I_I2S_FMT0_REG, 0, 2), .field_fmt_sr = REG_FIELD(SUN4I_I2S_FMT0_REG, 4, 6),
Hi Markus,
On Wed, Aug 21, 2019 at 06:23:20PM +0200, codekipper@gmail.com wrote:
From: Marcus Cooper codekipper@gmail.com
Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T") Signed-off-by: Marcus Cooper codekipper@gmail.com
The patch is ok, but you should have a commit log here.
Maxime
-- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
On Wed, Aug 21, 2019 at 06:23:20PM +0200, codekipper@gmail.com wrote:
From: Marcus Cooper codekipper@gmail.com
Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T") Signed-off-by: Marcus Cooper codekipper@gmail.com
This doesn't apply against current code, please check and resend.
On Fri, 30 Aug 2019 at 13:45, Mark Brown broonie@kernel.org wrote:
On Wed, Aug 21, 2019 at 06:23:20PM +0200, codekipper@gmail.com wrote:
From: Marcus Cooper codekipper@gmail.com
Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T") Signed-off-by: Marcus Cooper codekipper@gmail.com
This doesn't apply against current code, please check and resend.
This patch is no longer valid and the fix has been done through the reverts, BR, CK
participants (4)
-
Code Kipper
-
codekipper@gmail.com
-
Mark Brown
-
Maxime Ripard