[PATCH 00/18] ASoC: drop driver owner assignment
Core for several drivers already sets the driver.owner, so driver does not need to. Simplify the drivers.
Patches are independent, no dependencies.
Best regards, Krzysztof
--- Krzysztof Kozlowski (18): ASoC: loongson: i2s/pci: drop driver owner assignment ASoC: tlv320aic32x4-spi: drop driver owner assignment ASoC: tlv320aic3x-spi: drop driver owner assignment ASoC: max98373-sdw: drop driver owner assignment ASoC: rt1017-sdca-sdw: drop driver owner assignment ASoC: rt1308-sdw: drop driver owner assignment ASoC: rt1316-sdw: drop driver owner assignment ASoC: rt1318-sdw: drop driver owner assignment ASoC: rt5682-sdw: drop driver owner assignment ASoC: rt700-sdw: drop driver owner assignment ASoC: rt711-sdca-sdw: drop driver owner assignment ASoC: rt711-sdw: drop driver owner assignment ASoC: rt712-sdca-dmic: drop driver owner assignment ASoC: rt712-sdca-sdw: drop driver owner assignment ASoC: rt715-sdca-sdw: drop driver owner assignment ASoC: rt715-sdw: drop driver owner assignment ASoC: rt722-sdca-sdw: drop driver owner assignment ASoC: sdw-mockup: drop driver owner assignment
sound/soc/codecs/max98373-sdw.c | 1 - sound/soc/codecs/rt1017-sdca-sdw.c | 1 - sound/soc/codecs/rt1308-sdw.c | 1 - sound/soc/codecs/rt1316-sdw.c | 1 - sound/soc/codecs/rt1318-sdw.c | 1 - sound/soc/codecs/rt5682-sdw.c | 1 - sound/soc/codecs/rt700-sdw.c | 1 - sound/soc/codecs/rt711-sdca-sdw.c | 1 - sound/soc/codecs/rt711-sdw.c | 1 - sound/soc/codecs/rt712-sdca-dmic.c | 1 - sound/soc/codecs/rt712-sdca-sdw.c | 1 - sound/soc/codecs/rt715-sdca-sdw.c | 1 - sound/soc/codecs/rt715-sdw.c | 1 - sound/soc/codecs/rt722-sdca-sdw.c | 1 - sound/soc/codecs/sdw-mockup.c | 1 - sound/soc/codecs/tlv320aic32x4-spi.c | 1 - sound/soc/codecs/tlv320aic3x-spi.c | 1 - sound/soc/loongson/loongson_i2s_pci.c | 1 - 18 files changed, 18 deletions(-) --- base-commit: 1cadb9c1269d4e90ec23f3dc3e5373ee405462d1 change-id: 20240327-module-owner-var-2744d140fcdf
Best regards,
PCI core in pci_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/loongson/loongson_i2s_pci.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/loongson/loongson_i2s_pci.c b/sound/soc/loongson/loongson_i2s_pci.c index fa90361865c6..ec18b122cd79 100644 --- a/sound/soc/loongson/loongson_i2s_pci.c +++ b/sound/soc/loongson/loongson_i2s_pci.c @@ -160,7 +160,6 @@ static struct pci_driver loongson_i2s_driver = { .id_table = loongson_i2s_ids, .probe = loongson_i2s_pci_probe, .driver = { - .owner = THIS_MODULE, .pm = pm_sleep_ptr(&loongson_i2s_pm), }, };
Core in spi_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/tlv320aic32x4-spi.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/tlv320aic32x4-spi.c b/sound/soc/codecs/tlv320aic32x4-spi.c index d5976c91766e..92246243ff94 100644 --- a/sound/soc/codecs/tlv320aic32x4-spi.c +++ b/sound/soc/codecs/tlv320aic32x4-spi.c @@ -56,7 +56,6 @@ MODULE_DEVICE_TABLE(of, aic32x4_of_id); static struct spi_driver aic32x4_spi_driver = { .driver = { .name = "tlv320aic32x4", - .owner = THIS_MODULE, .of_match_table = aic32x4_of_id, }, .probe = aic32x4_spi_probe,
Core in spi_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/tlv320aic3x-spi.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/tlv320aic3x-spi.c b/sound/soc/codecs/tlv320aic3x-spi.c index deed6ec7e081..f8c1c16eaa0e 100644 --- a/sound/soc/codecs/tlv320aic3x-spi.c +++ b/sound/soc/codecs/tlv320aic3x-spi.c @@ -63,7 +63,6 @@ MODULE_DEVICE_TABLE(of, aic3x_of_id); static struct spi_driver aic3x_spi_driver = { .driver = { .name = "tlv320aic3x", - .owner = THIS_MODULE, .of_match_table = aic3x_of_id, }, .probe = aic3x_spi_probe,
Core in sdw_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/max98373-sdw.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/max98373-sdw.c b/sound/soc/codecs/max98373-sdw.c index 383e551f3bc7..26860882fd91 100644 --- a/sound/soc/codecs/max98373-sdw.c +++ b/sound/soc/codecs/max98373-sdw.c @@ -872,7 +872,6 @@ MODULE_DEVICE_TABLE(sdw, max98373_id); static struct sdw_driver max98373_sdw_driver = { .driver = { .name = "max98373", - .owner = THIS_MODULE, .of_match_table = of_match_ptr(max98373_of_match), .acpi_match_table = ACPI_PTR(max98373_acpi_match), .pm = &max98373_pm,
Core in sdw_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/rt1017-sdca-sdw.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/rt1017-sdca-sdw.c b/sound/soc/codecs/rt1017-sdca-sdw.c index 4dbbd8bdaaac..7c8103a0d562 100644 --- a/sound/soc/codecs/rt1017-sdca-sdw.c +++ b/sound/soc/codecs/rt1017-sdca-sdw.c @@ -809,7 +809,6 @@ static const struct dev_pm_ops rt1017_sdca_pm = { static struct sdw_driver rt1017_sdca_sdw_driver = { .driver = { .name = "rt1017-sdca", - .owner = THIS_MODULE, .pm = &rt1017_sdca_pm, }, .probe = rt1017_sdca_sdw_probe,
Core in sdw_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/rt1308-sdw.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/rt1308-sdw.c b/sound/soc/codecs/rt1308-sdw.c index 63d4abf964d4..563df483a466 100644 --- a/sound/soc/codecs/rt1308-sdw.c +++ b/sound/soc/codecs/rt1308-sdw.c @@ -804,7 +804,6 @@ static const struct dev_pm_ops rt1308_pm = { static struct sdw_driver rt1308_sdw_driver = { .driver = { .name = "rt1308", - .owner = THIS_MODULE, .pm = &rt1308_pm, }, .probe = rt1308_sdw_probe,
Core in sdw_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/rt1316-sdw.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/rt1316-sdw.c b/sound/soc/codecs/rt1316-sdw.c index 47511f70119a..aa7c0ca66877 100644 --- a/sound/soc/codecs/rt1316-sdw.c +++ b/sound/soc/codecs/rt1316-sdw.c @@ -781,7 +781,6 @@ static const struct dev_pm_ops rt1316_pm = { static struct sdw_driver rt1316_sdw_driver = { .driver = { .name = "rt1316-sdca", - .owner = THIS_MODULE, .pm = &rt1316_pm, }, .probe = rt1316_sdw_probe,
Core in sdw_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/rt1318-sdw.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/rt1318-sdw.c b/sound/soc/codecs/rt1318-sdw.c index ff364bde4a08..3f6c7c25967f 100644 --- a/sound/soc/codecs/rt1318-sdw.c +++ b/sound/soc/codecs/rt1318-sdw.c @@ -855,7 +855,6 @@ static const struct dev_pm_ops rt1318_pm = { static struct sdw_driver rt1318_sdw_driver = { .driver = { .name = "rt1318-sdca", - .owner = THIS_MODULE, .pm = &rt1318_pm, }, .probe = rt1318_sdw_probe,
Core in sdw_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/rt5682-sdw.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/rt5682-sdw.c b/sound/soc/codecs/rt5682-sdw.c index e67c2e19cb1a..43737d5cedd0 100644 --- a/sound/soc/codecs/rt5682-sdw.c +++ b/sound/soc/codecs/rt5682-sdw.c @@ -798,7 +798,6 @@ static const struct dev_pm_ops rt5682_pm = { static struct sdw_driver rt5682_sdw_driver = { .driver = { .name = "rt5682", - .owner = THIS_MODULE, .pm = &rt5682_pm, }, .probe = rt5682_sdw_probe,
Core in sdw_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/rt700-sdw.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/rt700-sdw.c b/sound/soc/codecs/rt700-sdw.c index 52c33d56b143..24cb895b759f 100644 --- a/sound/soc/codecs/rt700-sdw.c +++ b/sound/soc/codecs/rt700-sdw.c @@ -558,7 +558,6 @@ static const struct dev_pm_ops rt700_pm = { static struct sdw_driver rt700_sdw_driver = { .driver = { .name = "rt700", - .owner = THIS_MODULE, .pm = &rt700_pm, }, .probe = rt700_sdw_probe,
Core in sdw_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/rt711-sdca-sdw.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/rt711-sdca-sdw.c b/sound/soc/codecs/rt711-sdca-sdw.c index 935e597022d3..a7aa69495a7b 100644 --- a/sound/soc/codecs/rt711-sdca-sdw.c +++ b/sound/soc/codecs/rt711-sdca-sdw.c @@ -474,7 +474,6 @@ static const struct dev_pm_ops rt711_sdca_pm = { static struct sdw_driver rt711_sdca_sdw_driver = { .driver = { .name = "rt711-sdca", - .owner = THIS_MODULE, .pm = &rt711_sdca_pm, }, .probe = rt711_sdca_sdw_probe,
Core in sdw_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/rt711-sdw.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/rt711-sdw.c b/sound/soc/codecs/rt711-sdw.c index 3f5773310ae8..0d587f48439a 100644 --- a/sound/soc/codecs/rt711-sdw.c +++ b/sound/soc/codecs/rt711-sdw.c @@ -569,7 +569,6 @@ static const struct dev_pm_ops rt711_pm = { static struct sdw_driver rt711_sdw_driver = { .driver = { .name = "rt711", - .owner = THIS_MODULE, .pm = &rt711_pm, }, .probe = rt711_sdw_probe,
Core in sdw_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/rt712-sdca-dmic.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/rt712-sdca-dmic.c b/sound/soc/codecs/rt712-sdca-dmic.c index 0926b26619bd..0e4d7cbdc951 100644 --- a/sound/soc/codecs/rt712-sdca-dmic.c +++ b/sound/soc/codecs/rt712-sdca-dmic.c @@ -976,7 +976,6 @@ static int rt712_sdca_dmic_sdw_remove(struct sdw_slave *slave) static struct sdw_driver rt712_sdca_dmic_sdw_driver = { .driver = { .name = "rt712-sdca-dmic", - .owner = THIS_MODULE, .pm = &rt712_sdca_dmic_pm, }, .probe = rt712_sdca_dmic_sdw_probe,
Core in sdw_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/rt712-sdca-sdw.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/rt712-sdca-sdw.c b/sound/soc/codecs/rt712-sdca-sdw.c index 01ac555cd79b..f04e11980591 100644 --- a/sound/soc/codecs/rt712-sdca-sdw.c +++ b/sound/soc/codecs/rt712-sdca-sdw.c @@ -474,7 +474,6 @@ static const struct dev_pm_ops rt712_sdca_pm = { static struct sdw_driver rt712_sdca_sdw_driver = { .driver = { .name = "rt712-sdca", - .owner = THIS_MODULE, .pm = &rt712_sdca_pm, }, .probe = rt712_sdca_sdw_probe,
Core in sdw_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/rt715-sdca-sdw.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/rt715-sdca-sdw.c b/sound/soc/codecs/rt715-sdca-sdw.c index ab54a67a27eb..08db815d3c8e 100644 --- a/sound/soc/codecs/rt715-sdca-sdw.c +++ b/sound/soc/codecs/rt715-sdca-sdw.c @@ -270,7 +270,6 @@ static const struct dev_pm_ops rt715_pm = { static struct sdw_driver rt715_sdw_driver = { .driver = { .name = "rt715-sdca", - .owner = THIS_MODULE, .pm = &rt715_pm, }, .probe = rt715_sdca_sdw_probe,
Core in sdw_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/rt715-sdw.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/rt715-sdw.c b/sound/soc/codecs/rt715-sdw.c index 21f37babd148..823b9cacc3e2 100644 --- a/sound/soc/codecs/rt715-sdw.c +++ b/sound/soc/codecs/rt715-sdw.c @@ -577,7 +577,6 @@ static const struct dev_pm_ops rt715_pm = { static struct sdw_driver rt715_sdw_driver = { .driver = { .name = "rt715", - .owner = THIS_MODULE, .pm = &rt715_pm, }, .probe = rt715_sdw_probe,
Core in sdw_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/rt722-sdca-sdw.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/rt722-sdca-sdw.c b/sound/soc/codecs/rt722-sdca-sdw.c index eb76f4c675b6..27af5f883c08 100644 --- a/sound/soc/codecs/rt722-sdca-sdw.c +++ b/sound/soc/codecs/rt722-sdca-sdw.c @@ -503,7 +503,6 @@ static const struct dev_pm_ops rt722_sdca_pm = { static struct sdw_driver rt722_sdca_sdw_driver = { .driver = { .name = "rt722-sdca", - .owner = THIS_MODULE, .pm = &rt722_sdca_pm, }, .probe = rt722_sdca_sdw_probe,
Core in sdw_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- sound/soc/codecs/sdw-mockup.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/sdw-mockup.c b/sound/soc/codecs/sdw-mockup.c index 5498ff027c58..574c08b14f0c 100644 --- a/sound/soc/codecs/sdw-mockup.c +++ b/sound/soc/codecs/sdw-mockup.c @@ -262,7 +262,6 @@ MODULE_DEVICE_TABLE(sdw, sdw_mockup_id); static struct sdw_driver sdw_mockup_sdw_driver = { .driver = { .name = "sdw-mockup", - .owner = THIS_MODULE, }, .probe = sdw_mockup_sdw_probe, .remove = sdw_mockup_sdw_remove,
On 3/27/24 12:44, Krzysztof Kozlowski wrote:
Core for several drivers already sets the driver.owner, so driver does not need to. Simplify the drivers.
Nice cleanup, thanks.
Reviewed-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
On Wed, 27 Mar 2024 18:44:35 +0100, Krzysztof Kozlowski wrote:
Core for several drivers already sets the driver.owner, so driver does not need to. Simplify the drivers.
Patches are independent, no dependencies.
Best regards, Krzysztof
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[01/18] ASoC: loongson: i2s/pci: drop driver owner assignment commit: c335412ced27459b6ce71e812344a0bbaf43ab6a [02/18] ASoC: tlv320aic32x4-spi: drop driver owner assignment commit: 8a4836231c98bde3fa49ad657c09342d2d7e27a7 [03/18] ASoC: tlv320aic3x-spi: drop driver owner assignment commit: 54b8a522e67a8dfe135867c00f9fa297f0841c92 [04/18] ASoC: max98373-sdw: drop driver owner assignment commit: fe2065d645445dc2de61d9b336c41113759eef8a [05/18] ASoC: rt1017-sdca-sdw: drop driver owner assignment commit: d95c19aa2ca60010bb1976399b5a822ff165a8ef [06/18] ASoC: rt1308-sdw: drop driver owner assignment commit: b982047530d7a29eb68d42acaa19f249ac6ae5a7 [07/18] ASoC: rt1316-sdw: drop driver owner assignment commit: 7d5a2656626a6fbf573bde981c1550428a261cf2 [08/18] ASoC: rt1318-sdw: drop driver owner assignment commit: 3b7859dec834e96e8e833d2b2f2b4434e0e3b286 [09/18] ASoC: rt5682-sdw: drop driver owner assignment commit: e140dfeb1028ef49c34ae238863398c2c7e792f0 [10/18] ASoC: rt700-sdw: drop driver owner assignment commit: 554bec0c52dc6b6bbd605aa09462d15e9c41575b [11/18] ASoC: rt711-sdca-sdw: drop driver owner assignment commit: 852298a5e1ce7e72cb3c491bce3bca7262f6ef16 [12/18] ASoC: rt711-sdw: drop driver owner assignment commit: 37dc3531c56b86143b69576c4b56434d8bfcbf59 [13/18] ASoC: rt712-sdca-dmic: drop driver owner assignment commit: e50d2fbb6371f4d8482f5e4e112155278db6fc34 [14/18] ASoC: rt712-sdca-sdw: drop driver owner assignment commit: 7c00f1706e4b9ac02fdfb2a6b93b4487cbcefd3d [15/18] ASoC: rt715-sdca-sdw: drop driver owner assignment commit: d4f501e2926e32be76c0c564a634f06edef768bf [16/18] ASoC: rt715-sdw: drop driver owner assignment commit: eb9e0757976fdf34b65d70c7d25a7f0d3d1ecea9 [17/18] ASoC: rt722-sdca-sdw: drop driver owner assignment commit: 8c70ce6108cda5c36b9c4e66b1fd7dc8ded2a7d6 [18/18] ASoC: sdw-mockup: drop driver owner assignment commit: 29580cd7b9c6f975e88597ca66a001b16b97bae9
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (3)
-
Krzysztof Kozlowski -
Mark Brown -
Pierre-Louis Bossart