On Mon, May 11, 2015 at 02:33:36AM +0000, John Lin wrote:

...

-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Saturday, May 09, 2015 1:14 AM To: John Lin Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; Bard Liao; Flove; Oder Chiou; koro.chen@mediatek.com; yang.a.fang@intel.com; zhengxing@rock-chips.com Subject: Re: [PATCH 1/2] ASoC: rt5645: fix jack type detect error

...

On Fri, May 08, 2015 at 01:53:33PM +0800, John Lin wrote:

...

rt5645_jack_detect doesn't report the correct jack type consistently. This patch can make it more stable.

...

Can you be more specific about what the problem is and how this fixes it pleased? It's a bit hard to review based on your changelog.

It mistakes OMTP type headset to CTIA type if "LDO2" power is disable in jack detection function. So, we keep "LDO2" power enabled until jack out. We also change the register sequence to make it more stable and remove unnecessary power such as "micbias1" and "micbias2" for jack detection.

This stuff needs to be in the changelog. It also sounds like there's at least two probably three patches here - one to keep the LDO power enabled for lonnger and one or more changes to the register sequence.