Re: [alsa-devel] [PATCH] ALSA: pcm: Revert capture stream behavior change in blocking mode
8 Feb
2019
8 Feb
'19
6:46 p.m.
Takashi Iwai wrote:
e.g. one thread goes to a write loop in blocking mode while another thread controls the start/stop of the stream manually.
You meant a read loop. Agreed.
What about adding a comment like:
/* * If size < start_threshold, wait indefinitely. Another * thread may start capture */
So no one will bring this idea again.
pasquali
8 Feb
8 Feb
7:56 p.m.
New subject: [alsa-devel] [PATCH] ALSA: pcm: Revert capture stream behavior change in blocking mode
On Fri, 08 Feb 2019 18:46:12 +0100, Ricardo Biehl Pasquali wrote:
Takashi Iwai wrote:
e.g. one thread goes to a write loop in blocking mode while another thread controls the start/stop of the stream manually.
You meant a read loop. Agreed.
What about adding a comment like:
/*
- If size < start_threshold, wait indefinitely. Another
- thread may start capture
*/
So no one will bring this idea again.
Yes, more comment might be helpful. Feel free to submit a patch to add that.
thanks,
Takashi
2144
Age (days ago)
2144
Last active (days ago)
1 comments
2 participants
participants (2)
-
Ricardo Biehl Pasquali -
Takashi Iwai