Re: [alsa-devel] [PATCH v2 1/3]AsoC/nuc900: patch for SUBSTREAM_TYPE', 'PCM_TX' and 'PCM_RX' removal
On Wed, 2010-06-02 at 13:54 +0800, Wan ZongShun wrote:
This patch is to remove the 'SUBSTREAM_TYPE','PCM_TX' and 'PCM_RX' definition.
There is no need to redefine SNDRV_PCM_STREAM_PLAYBACK as PCM_TX, the SUBSTREAM_TYPE(substream) can be deleted too, the playback or record can be judged by 'if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)' directly rather than 'if (PCM_TX == stype)', which makes the codes easy to read.
Signed-off-by: Wan ZongShunmcuos.com@gmail.com
All
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
On Wed, Jun 02, 2010 at 10:43:07AM +0100, Liam Girdwood wrote:
On Wed, 2010-06-02 at 13:54 +0800, Wan ZongShun wrote:
This patch is to remove the 'SUBSTREAM_TYPE','PCM_TX' and 'PCM_RX' definition.
There is no need to redefine SNDRV_PCM_STREAM_PLAYBACK as PCM_TX, the SUBSTREAM_TYPE(substream) can be deleted too, the playback or record can be judged by 'if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)' directly rather than 'if (PCM_TX == stype)', which makes the codes easy to read.
Signed-off-by: Wan ZongShunmcuos.com@gmail.com
Note here that you're still missing a space betwen your name and e-mail address.
All
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
I've applied all the patches, since I had to fix up the changelogs anyway I updated the ms to us in the changelog for patch 2. Thanks.
2010/6/2 Mark Brown broonie@opensource.wolfsonmicro.com:
On Wed, Jun 02, 2010 at 10:43:07AM +0100, Liam Girdwood wrote:
On Wed, 2010-06-02 at 13:54 +0800, Wan ZongShun wrote:
This patch is to remove the 'SUBSTREAM_TYPE','PCM_TX' and 'PCM_RX' definition.
There is no need to redefine SNDRV_PCM_STREAM_PLAYBACK as PCM_TX, the SUBSTREAM_TYPE(substream) can be deleted too, the playback or record can be judged by 'if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)' directly rather than 'if (PCM_TX == stype)', which makes the codes easy to read.
Signed-off-by: Wan ZongShunmcuos.com@gmail.com
Note here that you're still missing a space betwen your name and e-mail address.
Okay, thank you. but I use 'scripts/checkpatch.pl' to check my patch, it seems no warning or error.:)
All
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
I've applied all the patches, since I had to fix up the changelogs anyway I updated the ms to us in the changelog for patch 2. Thanks. _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Hi Mark,
2010/6/2 Mark Brown broonie@opensource.wolfsonmicro.com:
On Wed, Jun 02, 2010 at 10:43:07AM +0100, Liam Girdwood wrote:
On Wed, 2010-06-02 at 13:54 +0800, Wan ZongShun wrote:
This patch is to remove the 'SUBSTREAM_TYPE','PCM_TX' and 'PCM_RX' definition.
There is no need to redefine SNDRV_PCM_STREAM_PLAYBACK as PCM_TX, the SUBSTREAM_TYPE(substream) can be deleted too, the playback or record can be judged by 'if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)' directly rather than 'if (PCM_TX == stype)', which makes the codes easy to read.
Signed-off-by: Wan ZongShunmcuos.com@gmail.com
Note here that you're still missing a space betwen your name and e-mail address.
Do I need re-sent this patch with the missing space fix?
All
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
I've applied all the patches, since I had to fix up the changelogs anyway I updated the ms to us in the changelog for patch 2. Thanks. _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
On Sat, Jun 05, 2010 at 03:08:42PM +0800, Wan ZongShun wrote:
Do I need re-sent this patch with the missing space fix?
No. Like I said:
I've applied all the patches, since I had to fix up the changelogs anyway I updated the ms to us in the changelog for patch 2. Thanks.
participants (3)
-
Liam Girdwood -
Mark Brown -
Wan ZongShun