Re: [alsa-devel] [PATCH]ASOC:DAPM: update DPCM runtime when mixer/mux changes
<This patch is dependent on the $subject so i have used $subject instead of different one> I can see only one usage of: snd_soc_dapm_mixer_update_power and zero user of: snd_soc_dapm_mux_update_power()
And after this $subject patch I think both of these functions becomes redundant.
It will help in reducing the code size if we can get rid of this dead code.We can also remove code from tlv320aic3x.c and just let it use the core implementation.
grep -rniI "snd_soc_dapm_mixer_update_power" sound/
sound/soc/soc-dapm.c:2149: int snd_soc_dapm_mixer_update_power sound/soc/codecs/tlv320aic3x.c:174: snd_soc_dapm_mixer_update_power
grep -rniI "snd_soc_dapm_mux_update_power" sound/ no users.
I would send a patch if experts agree.
On 12/16/2013 09:03 AM, anish singh wrote:
<This patch is dependent on the $subject so i have used $subject instead of different one> I can see only one usage of: snd_soc_dapm_mixer_update_power and zero user of: snd_soc_dapm_mux_update_power()
And after this $subject patch I think both of these functions becomes redundant.
No, the patch doesn't change anything in regard to those two functions. Those two functions are used by drivers where the mixer or mux has a special register layout that is not covered by the core mixer and mux update functions and where does not make sense to add support for this to the core functions since the layout is special.
It will help in reducing the code size if we can get rid of this dead code.We can also remove code from tlv320aic3x.c and just let it use the core implementation.
The tlv320aic3x driver has special requirements, hence it has its own function for updating the mux settings.
- Lars
participants (2)
-
anish singh -
Lars-Peter Clausen