On Sunday 12 of April 2009 19:00:37 Mark Brown wrote:

On Sun, Apr 12, 2009 at 04:47:39PM +0200, Marek Vasut wrote:

...

One more thing, I'd like to ask how to change the reset_gpio in the above file. Will I have to make copy of pxa_ac97_dai[PXA2XX_DAI_AC97_HIFI] in palm27x.c and change the .probe pointer to my own function that sets the proper platform data? That is, something like the following? Thanks

BTW, I meant to say in reply to the previous mail - you really should copy all audio discussion to at least alsa-devel.

...

+/* Palms use GPIO95 for AC97 reset */ +static int palm_ac97_probe(struct platform_device *pdev,

•                        struct snd_soc_dai *dai)
  

+{

•   struct platform_device *pd = to_platform_device(dai->dev);
  

•   static struct pxa2xx_ac97_platform_data pdata = {
  

•           .reset_gpio = 95,
  

•   };
  

•   printk("%s[%i]\n", __FUNCTION__, __LINE__);
  

•   pd->dev.platform_data = &pdata;
  

•   return pxa2xx_ac97_hw_probe(pd);
  

+}

Look in mainline - pxa2xx-ac97-lib already provides platform data based configuration of the GPIO to use for reset.

Yes, I sent the new version and CCed alsa-devel.