[alsa-devel] question about two ASoC commits
Hi
Can anyone tell me what is the reasoning of the following two commits commit: 5d16333 ASoC: SND_SOC_DAIFMT_NB_NF become 0 as default settings commit: eef28e1 ASoC: SND_SOC_DAIFMT_GATED become 0 as default settings
with these two commits, now we have #define SND_SOC_DAIFMT_GATED (0 << 4) #define SND_SOC_DAIFMT_NB_NF (0 << 8) in soc-dai.h what's the good to shift 0 with different numbers? no matter the number, they both equal to 0.
IMO all bit flags which share same variable (in this case SND_SOC_DAIFMT) should have different value, isn't it?
Thanks, Jiada
On Tue, Sep 09, 2014 at 05:36:36PM +0900, jiwang wrote:
Can anyone tell me what is the reasoning of the following two commits commit: 5d16333 ASoC: SND_SOC_DAIFMT_NB_NF become 0 as default settings commit: eef28e1 ASoC: SND_SOC_DAIFMT_GATED become 0 as default settings
with these two commits, now we have #define SND_SOC_DAIFMT_GATED (0 << 4) #define SND_SOC_DAIFMT_NB_NF (0 << 8) in soc-dai.h what's the good to shift 0 with different numbers? no matter the number, they both equal to 0.
IMO all bit flags which share same variable (in this case SND_SOC_DAIFMT) should have different value, isn't it?
As the commit message says this is so that we have a default value which does something sensible.
participants (2)
-
jiwang -
Mark Brown